Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after update of authentic-theme i was redirected to my 'Default module for Webmin' #882

Closed
Sopor opened this issue Nov 8, 2017 · 8 comments

Comments

@Sopor
Copy link
Contributor

Sopor commented Nov 8, 2017

If i don't have set any 'Default module for Webmin' i get redirected to the Dashboard but if i have set the 'Default module for Webmin' i get redirected to this page after an update of the authentic-theme.
Is this really correct?

@iliajie
Copy link
Collaborator

iliajie commented Nov 8, 2017

By default, when you reload the page, you will be taken not to default module for Webmin but to previously used page.

After theme update - page reload happens. You should be taken to Theme Settings in case you run update from there or to System Information page or to any other page, in case you trigger update from the Side Slider.

@iliajie iliajie closed this as completed Nov 8, 2017
@Sopor
Copy link
Contributor Author

Sopor commented Nov 8, 2017

I that case something is wrong. I will get to the 'Default module for Webmin' (i have it set for 'Read user mail' and that page will show up after the theme update) every time after an update. To get to the Dashboard i need to empty the 'Default module for Webmin'...

@iliajie
Copy link
Collaborator

iliajie commented Nov 8, 2017

Yes, in case you clear default module, System Information becomes default.

If you go to any page, let's say Webmin Configuration and then reload the page after few seconds. Will you get back to exact the same page after the reload?

@Sopor
Copy link
Contributor Author

Sopor commented Nov 8, 2017

In that case the 'Default module for Webmin' is useless for me. I want to get back to the Dashboard but it is sad that i can't use the Webmin button because now that button do nothing :(

@iliajie
Copy link
Collaborator

iliajie commented Nov 8, 2017

When you click Webmin switch (top of navigation menu) you must get to default Webmin module, that is set in theme's settings (that corresponds with Webmin Configuration by the way). Same happens in case you click on Virtualmin/Cloudmin switch.

In case you click on Dashboard switch (which is only visible if there is no Virtualmin/Cloudmin modules installed), then you must get to System Page (always).

If you reload the page, then you should get to the previously used page. Isn't that what's happening for you?

@Sopor
Copy link
Contributor Author

Sopor commented Nov 8, 2017

What i do is:

  1. Open theme configuration.
  2. Set Default module for Webmin to Read user mail and save it.
  3. Go back to the Dashboard by clicking the Dashboard switch.
  4. To update i open the theme configuration.
  5. I use the Force update theme.
  6. When it is finished it will now show the Read user mail page instead of the Dashboard.

The Webmin switch seems to be nice to use as a shortcut button or something, but i don't want it to be the default page after an update. But i leave the Default module for Webmin empty and use it as i did before, or should i say i don't use it.

@iliajie
Copy link
Collaborator

iliajie commented Nov 9, 2017

Alright, I don't disagree. I like the idea of returning to System Information page after update. I will do it.

Plus I will add a control to Side Slider, where you could run theme info, apply update and do more with one click.

@iliajie
Copy link
Collaborator

iliajie commented Nov 9, 2017

Give it a try.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants