Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very fast progress indicator on slow systems #913

Closed
Sopor opened this issue Dec 2, 2017 · 19 comments
Closed

very fast progress indicator on slow systems #913

Sopor opened this issue Dec 2, 2017 · 19 comments

Comments

@Sopor
Copy link
Contributor

Sopor commented Dec 2, 2017

When i for example refresh the modules the red progress indicator at the top of the page goes very quickly from left to right and when there is only a few percent left it will get stuck there for a long time. It is very hard to see if the page is working or if it got stuck or maybe it is already finish.
From 0%-98% it takes 10 seconds and from 98%-100% it takes 37 seconds.
image

@gnadelwartz
Copy link
Contributor

the progress indicator does not show real progress, its only an indicator that the theme is waiting for data to be transfered.

additional question: which system is slow, client or server running webmin? guessthe latter.

@qooob may be the progress indicator can start over instead of waiting for data and staying at 98%?

@iliajie
Copy link
Collaborator

iliajie commented Dec 3, 2017

It's not natural for it to start over. The only thing I can do right now is to decrease its rate and speed. It will go directly to the release within 3 hours.

@iliajie iliajie closed this as completed Dec 3, 2017
@Sopor
Copy link
Contributor Author

Sopor commented Dec 3, 2017

No big difference than before. From 0-98 it will take 15 seconds and from 98-100 it will take 32 seconds.

@iliajie
Copy link
Collaborator

iliajie commented Dec 3, 2017

Server response can be different. We never know how long it's gonna be.

How do you expect progress behave?

@Sopor
Copy link
Contributor Author

Sopor commented Dec 3, 2017

Isn't it possible to have something like this or this?

@iliajie
Copy link
Collaborator

iliajie commented Dec 3, 2017

I don't think so..

Unless it's constantly moving and occupying the whole width right at once.

What others think?

@gnadelwartz
Copy link
Contributor

I think the simplest way is to start over if the inidicator reaches the end, so you know we are waiting ...

alternative may be switch to a circling loading indicator instead

@mgancarzdsi
Copy link

If there is no way to know how long, a looping one is only solution. Preferably with some message such as "Waiting for server" or something

@Sopor
Copy link
Contributor Author

Sopor commented Dec 5, 2017

How about having a red line that goes back and forth?
theme-anim

@iliajie
Copy link
Collaborator

iliajie commented Dec 5, 2017

I like it, actually. :)

@Sopor
Copy link
Contributor Author

Sopor commented Dec 5, 2017

Maybe the speed could have an option so the user could adjust how fast it should go back and forth?
If your computer is fast and modern the bar need to go faster or else it won't move very far and if you have an older slower computer it will be very annoying to have a bar that goes back and forth very fast.

@iliajie
Copy link
Collaborator

iliajie commented Dec 5, 2017

I think I will remove all js libraries for this and simply replace it with few lines of css code. Emplementation of progress is abstracted so replacing it will be very easy.

iliajie pushed a commit that referenced this issue Dec 5, 2017
@iliajie
Copy link
Collaborator

iliajie commented Dec 5, 2017

Alright, let's keep it repeating so far. In the future, I will come up with more fancy CSS animation.

Tell me how you like it. It uses no JS now. So one dependency less.

@gnadelwartz
Copy link
Contributor

gnadelwartz commented Dec 5, 2017

there is not much difference. moves from left to right, sometimes halts and stay at 98% if a module needs log time to load.

if someone is looking for a module with long loading time, try read user mail :) if you have users with big mailboxes

@iliajie
Copy link
Collaborator

iliajie commented Dec 5, 2017

@gnadelwartz I have no idea what you mean by "no difference".

The loader now automatically restarts. Exactly addresses the initial issue.

Have a look at my video-screencast.

@iliajie
Copy link
Collaborator

iliajie commented Dec 5, 2017

Okay, I think I know why it's not working for you. Firefox 57 unlike 59a and Chromium doesn't recognize 0 in @Keyframes.

I will update it very soon.

@gnadelwartz
Copy link
Contributor

gnadelwartz commented Dec 5, 2017

yes Im using firefox and yandex (a chrome clone) but I don't bother because in a few weeks I'll have FF59 😁

@iliajie
Copy link
Collaborator

iliajie commented Dec 5, 2017

Okay, I have fixed my local compilers to make sure latest code styles are considered.

You can upgrade now. It will use fancy loaders.

In case it's fast - it will be as used to be.

In case it's slow or something big is updating, it's going to be bouncing back and forth.

I hope you like it @Sopor- .

Let me know more.

@Sopor
Copy link
Contributor Author

Sopor commented Dec 5, 2017

Now it will work as it did before but if the server is slow it will start to go backwards.
@qooob It looks very nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants