Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Bootup and Shutdown module is broken, displaying empty editor #928

Closed
matrix200 opened this issue Dec 10, 2017 · 19 comments
Closed
Labels

Comments

@matrix200
Copy link

It is no longer possible to edit init scripts using the module.
Steps to reproduce:

  1. Open Bootup and Shutdown module (under system).
  2. Click on any upstart click from the list
    Result:
    The following screen is displayed and it is impossible to edit the script in anyway.
    See attached screenshot:
    screenshot

Server side OS: Centos 6.9
Client side: Windows 7x64, browser Palemoon 27.6.2 (32bit).

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

I can confirm that content is empty.

Very surprising. I will double-check why this is happening.

Thank you for reporting.

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

I found the cause of the issue.

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

Will be fixed accordingly.

@matrix200
Copy link
Author

That was quick :)

@matrix200
Copy link
Author

I think its prudent to release a small webmin update for that issue.
Jamie should probably be informed about this as well.

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

It's caused by third-party library that needs to be fixed to make it work with Webmin expectations.


P.S. I remember about your SysStat question, I just don't have much to say right now. I will get back to that issue later.

@matrix200
Copy link
Author

Sure, no pressure on that one.

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

It's fixed in
2175a3a

Please give it a try.

@iliajie iliajie closed this as completed Dec 10, 2017
@matrix200
Copy link
Author

I have replaced the two changed files from that branch and the problem is still there.

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

You need to make sure that you clear browser's cache and reload the page/theme.

@matrix200
Copy link
Author

OK sorry, I had to force reload in browser.
That problem is now solved, but your fix broke a bunch of other stuff.
Namely all the icons are missing
Let me attach a screenshot

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

Just go to theme's settings and run force upgrade with development version.

@matrix200
Copy link
Author

Now it works :)

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

👍

@matrix200
Copy link
Author

Edit action is fixed and the webmin is back to normal.

@matrix200
Copy link
Author

Like I said, I think its a good idea to inform Jamie and possibly release and updated webmin version.
Otherwise, there will be alot of complaints about that.

@harms916
Copy link

harms916 commented Jan 5, 2018

I just noticed today that the Edit Action on the Bootup and Shutdown works on some of the services but on others it still loads the blank page as descibed above.
Running Ubuntu 14.04, Webmin 1.87, Authentic Theme version 19.04 and when I try and edit the apparmor, dns-clean, grub-common, halt, webmin service and unifi I still get the blank page.
If you change the theme to the default it works as expected.

@iliajie
Copy link
Collaborator

iliajie commented Jan 5, 2018

Yes. 19.04 is affected. Please Force update to the latest using theme configuration page and Force update theme option.

@harms916
Copy link

harms916 commented Jan 5, 2018

Beautiful. That did the trick. Thanks

@iliajie iliajie changed the title Bootup and Shutdown module is broken Theme: Bootup and Shutdown module is broken, displaying empty editor Sep 30, 2018
@iliajie iliajie added the bug label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants