Skip to content
This repository has been archived by the owner on Sep 10, 2019. It is now read-only.

Commit

Permalink
[BUG #8960] Removed logger statement in the tests
Browse files Browse the repository at this point in the history
  • Loading branch information
wittemann committed Feb 24, 2015
1 parent a979785 commit 2236b60
Show file tree
Hide file tree
Showing 11 changed files with 10 additions and 42 deletions.
7 changes: 6 additions & 1 deletion framework/source/class/qx/log/appender/Native.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,19 @@ qx.Class.define("qx.log.appender.Native",
{
statics :
{
/**
* Silent mode prevents loggin useful for testing purposes.
*/
SILENT: false,

/**
* Processes a single log entry
*
* @param entry {Map} The entry to process
*/
process : function(entry) {
var level = entry.level;
if (console && console[level]) {
if (console && console[level] && !qx.log.appender.Native.SILENT) {
var args = qx.log.appender.Util.toText(entry);
console[level](args);
}
Expand Down
4 changes: 0 additions & 4 deletions framework/source/test/tests/Xml.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ describe("Xml", function() {
var data = "<Root><Row>test1</Row><Row>test2</Row><Row>test3</Row></Root>";

var xml = qx.xml.Document.fromString(data);
// qx.log.Logger.debug("Converted to XML Document ", xml);
});


Expand Down Expand Up @@ -112,11 +111,9 @@ describe("Xml", function() {
} else {
var n1 = qx.xml.Element.selectSingleNode(doc, q1, nsMap);
var s1 = qx.xml.Element.serialize(n1);
// qx.log.Logger.debug("Found node: " + s1);
assert.equal(s1, emStr);
var n2 = qx.xml.Element.selectSingleNode(doc, q2, nsMap);
var s2 = qx.xml.Element.serialize(n2);
// qx.log.Logger.debug("Found node: " + s2);
assert.equal(s2, fooStr);
var n3 = qx.xml.Element.selectNodes(doc, q3, nsMap);
var n4 = qx.xml.Element.selectNodes(n3[0], q2, nsMap);
Expand All @@ -139,7 +136,6 @@ describe("Xml", function() {

var templates = qx.xml.Element.getElementsByTagNameNS(nsDoc, "http://www.w3.org/1999/XSL/Transform", "template");

// qx.log.Logger.debug(qx.xml.String.escape(serializeArray(templates)));
assert.equal(2, templates.length, "getElementsByTagNameNS for XML documents failed!");

assert.equal("xsl:template", templates[0].tagName, "getElementsByTagNameNS for XML documents failed!");
Expand Down
5 changes: 0 additions & 5 deletions framework/source/test/tests/bom/Basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,12 @@ describe("bom.Basic", function() {
assert.isFalse(attrib.get(test3, "disabled"));
assert.equal(2, attrib.get(test3, "tabindex"));

qx.log.Logger.info("test4");
assert.isTrue(attrib.get(document.getElementById("test4"), "disabled"));
assert.isFalse(attrib.get(document.getElementById("test4"), "readonly"));

qx.log.Logger.info("test5");
assert.isTrue(attrib.get(document.getElementById("test5"), "disabled"));
assert.isTrue(attrib.get(document.getElementById("test5"), "readonly"));

qx.log.Logger.info("test6");
assert(qx.lang.String.endsWith(attrib.get(document.getElementById("test6"), "href"), "/foo.html"));

var test6Color = style.get(document.getElementById("test6"), "color");
Expand All @@ -90,11 +87,9 @@ describe("bom.Basic", function() {
assert.equal("Foo-Link", attrib.get(document.getElementById("test6"), "text"));
assert.equal("<b>foo</b>-link", attrib.get(document.getElementById("test6"), "html").toLowerCase());

qx.log.Logger.info("test7");
assert.equal("bottom", attrib.get(document.getElementById("test7"), "valign"));
assert.equal(3, attrib.get(document.getElementById("test7").getElementsByTagName("td")[0], "colspan"));

qx.log.Logger.info("test8");
style.set(document.getElementById("test8"), "color", "red");
style.set(document.getElementById("test8"), "backgroundColor", "black");

Expand Down
6 changes: 0 additions & 6 deletions framework/source/test/tests/bom/Event.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ describe("bom.Event", function() {
el = qx.dom.Element.create("div", {
name: "vanillebaer"
}, window);
qx.bom.Event.addNativeListener(el, eventsToCheck[i], function(e) {
qx.log.Logger.info("done");
});
assert.isTrue(qx.bom.Event.supportsEvent(el, eventsToCheck[i]), "Failed to check support for '" + eventsToCheck[i] + "'");
}

Expand All @@ -56,9 +53,6 @@ describe("bom.Event", function() {
el = qx.dom.Element.create("div", {
name: "vanillebaer"
}, window);
qx.bom.Event.addNativeListener(el, pointerEventsToCheck[i], function(e) {
qx.log.Logger.info("done");
});
assert.isTrue(qx.bom.Event.supportsEvent(el, pointerEventsToCheck[i]), "Failed to check support for '" + pointerEventsToCheck[i] + "'");
}
}
Expand Down
3 changes: 0 additions & 3 deletions framework/source/test/tests/bom/client/Device.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,14 @@ describe("bom.client.Device", function() {


for (var i = 0; i < mobileUserAgentTests.length; i++) {
qx.log.Logger.info("Mobile User Agent Testing:" + mobileUserAgentTests[i]);
assert.equal("mobile", qx.bom.client.Device.detectDeviceType(mobileUserAgentTests[i]), "Expected User Agent string to be detected as a mobile device: " + mobileUserAgentTests[i]);
}

for (i = 0; i < tabletUserAgentTests.length; i++) {
qx.log.Logger.info("Tablet User Agent Testing:" + tabletUserAgentTests[i]);
assert.equal("tablet", qx.bom.client.Device.detectDeviceType(tabletUserAgentTests[i]), "Expected User Agent string to be detected as a tablet device: " + tabletUserAgentTests[i]);
}

for (i = 0; i < desktopUserAgentTests.length; i++) {
qx.log.Logger.info("Desktop User Agent Testing:" + desktopUserAgentTests[i]);
assert.equal("desktop", qx.bom.client.Device.detectDeviceType(desktopUserAgentTests[i]), "Expected User Agent string to be detected as a desktop device:" + desktopUserAgentTests[i]);
}

Expand Down
1 change: 0 additions & 1 deletion framework/source/test/tests/data/singlevalue/Array.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ describe("data.singlevalue.Array", function() {

// change the array itself
__a.array = (new qx.data.Array(1, 2, 3));
qx.log.Logger.debug(__a.array.getItem(0));
// check the binding
assert.equal("1", __label.value, "Changing the array does not work!");
});
Expand Down
2 changes: 0 additions & 2 deletions framework/source/test/tests/dom/Node.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ describe("dom.Node", function() {

blockElements.push(blockElement);

qx.log.Logger.info("Testing node " + qx.dom.Node.getName(blockElement));
assert.isTrue(qx.dom.Node.isBlockNode(blockElement));
}
});
Expand All @@ -67,7 +66,6 @@ describe("dom.Node", function() {

inlineElements.push(inlineElement);

qx.log.Logger.info("Testing node " + qx.dom.Node.getName(inlineElement));
assert.isFalse(qx.dom.Node.isBlockNode(inlineElement));
}
});
Expand Down
19 changes: 0 additions & 19 deletions framework/source/test/tests/io/MRemoteTest.js

This file was deleted.

2 changes: 2 additions & 0 deletions framework/source/test/tests/log/Logger.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ describe("log.Logger", function() {
var TEST_CONSTANT = "abc";

beforeEach(function() {
qx.log.appender.Native.SILENT = true;
__initialLogLevel = qx.log.Logger.getLevel();
});


afterEach(function() {
qx.log.appender.Native.SILENT = false;
qx.log.Logger.setLevel(__initialLogLevel);
});

Expand Down
2 changes: 2 additions & 0 deletions framework/source/test/tests/log/RingBuffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ describe("log.RingBuffer", function ()

beforeEach (function ()
{
qx.log.appender.Native.SILENT = true;
__initialLogLevel = qx.log.Logger.getLevel();
});

afterEach (function ()
{
qx.log.appender.Native.SILENT = false;
qx.log.Logger.setLevel(__initialLogLevel);
});

Expand Down
1 change: 0 additions & 1 deletion framework/source/test/tests/ui/Image.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ describe("ui.Image", function() {
it("Src", function(done) {
var source = "../resource/qx/static/blank.png";
if (qx.io.ImageLoader.isLoaded(source)) {
console.warn("ui.Image.testLoadedEvent skipped! Image already loaded.");
this.test.skip = true;
return;
}
Expand Down

0 comments on commit 2236b60

Please sign in to comment.