Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

APIfy website generation #462

Merged
merged 13 commits into from Jun 24, 2019
Merged

APIfy website generation #462

merged 13 commits into from Jun 24, 2019

Conversation

cboulanger
Copy link
Contributor

In preparation of #452 , this moves the build scripts for the local website into the qx.tool.utils.Website class to make them callable from the CLI code.

@cboulanger
Copy link
Contributor Author

cboulanger commented Jun 22, 2019

This removes the qx/source/resource/website/build folder and builds the local website on demand the first time it is used. It can be rebuilt using the qx serve -R option. Once @hkollmann adds statically built qxl.* apps to the NPM package, we can switch to linking to them from the local web page.

Copy link
Member

@hkollmann hkollmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the shurtcuts in serve. IMHO you should Change them in compile too so that they are equal. Eventually we can use a mixin here so that we do not have the same Code in 2 places?

Copy link
Member

@johnspackman johnspackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pages should be recompiled automatically if the version number changes eg as Maker will delete the output directory if it changes. Maybe --clean should do the same?

@cboulanger
Copy link
Contributor Author

@johnspackman can you elaborate?

Local building of Dev Tools will be handled in `qx serve`
@hkollmann
Copy link
Member

Great! We should think About if if use the builder construction for all commands. But not in this PR.

@cboulanger
Copy link
Contributor Author

@hkollmann You're right, for example -v/--verbose should be inherited rather than repeated in each builder... can you put this into a separate issue?

@johnspackman
Copy link
Member

@johnspackman can you elaborate?

if the compiler version number changes, the compiler will delete the output directory before starting the compile (that link to the Maker class was to illustrate where). IMHO a similar detection for the compilation, when the version number changes it gets recompiled.

OTOH, unless there is a need to compile it with a user's project code, I don 't understand why this does not remain part of the deployment of new qx versions.

@cboulanger
Copy link
Contributor Author

@johnspackman The reason I removed the build was that 1) it seemed strange to me to change the same things at two places: in the source and the build version, and 2) that I thought that it would be good to be able to dynamically change the local website based on specific configurations (for example, to link to locally built playground versus the one on the qooxdoo website). Since then, @hkollmann has rightly suggested that it makes more sense to include those apps pre-built in the NPM package - and I think that applies to the local website as well. Would you support this solution - to make website building part of the NPM deployment?

@johnspackman
Copy link
Member

@cboulanger yes, I think inclusion in the npm deployment is ideal

@johnspackman johnspackman merged commit 4f05ad3 into master Jun 24, 2019
@johnspackman
Copy link
Member

merging, thank you @cboulanger

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants