-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
This removes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You changed the shurtcuts in serve. IMHO you should Change them in compile too so that they are equal. Eventually we can use a mixin here so that we do not have the same Code in 2 places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pages should be recompiled automatically if the version number changes eg as Maker will delete the output directory if it changes. Maybe --clean
should do the same?
@johnspackman can you elaborate? |
Local building of Dev Tools will be handled in `qx serve`
Great! We should think About if if use the builder construction for all commands. But not in this PR. |
@hkollmann You're right, for example |
if the compiler version number changes, the compiler will delete the output directory before starting the compile (that link to the Maker class was to illustrate where). IMHO a similar detection for the compilation, when the version number changes it gets recompiled. OTOH, unless there is a need to compile it with a user's project code, I don 't understand why this does not remain part of the deployment of new qx versions. |
@johnspackman The reason I removed the build was that 1) it seemed strange to me to change the same things at two places: in the source and the build version, and 2) that I thought that it would be good to be able to dynamically change the local website based on specific configurations (for example, to link to locally built playground versus the one on the qooxdoo website). Since then, @hkollmann has rightly suggested that it makes more sense to include those apps pre-built in the NPM package - and I think that applies to the local website as well. Would you support this solution - to make website building part of the NPM deployment? |
@cboulanger yes, I think inclusion in the npm deployment is ideal |
merging, thank you @cboulanger |
In preparation of #452 , this moves the build scripts for the local website into the
qx.tool.utils.Website class
to make them callable from the CLI code.