Skip to content

Commit

Permalink
Enable icon for qx.bom.Notification for newer FF versions
Browse files Browse the repository at this point in the history
At least FF 46 supports icons in notifications.
  • Loading branch information
level420 committed May 12, 2016
1 parent aee8627 commit 71f8d9d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions framework/source/class/qx/bom/Notification.js
Expand Up @@ -205,9 +205,11 @@ qx.Class.define("qx.bom.Notification", {
icon = rm.toUri(source);
}

// Skip icon for firefox browsers for now, because they will
// not show any message
if (qx.core.Environment.get("engine.name") == "gecko") {
// old versions of firefox did not display the notification if
// an icon was specified, so we disable the icon for firefox
// < version 46
if (qx.core.Environment.get("engine.name") == "gecko" &&
qx.core.Environment.get("browser.version") < 46) {
icon = undefined;
}
}
Expand Down

0 comments on commit 71f8d9d

Please sign in to comment.