fixes punycode warning #10678
Merged
fixes punycode warning #10678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnspackman
requested review from
oetiker,
level420,
cboulanger,
derrell,
hkollmann,
lucapivato and
goldim
as code owners
Closed
oetiker
approved these changes
Mar 27, 2024
derrell
approved these changes
Mar 27, 2024
…doo into fix-punycode-warning-2
goldim
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Wanna pay your attention on know-good compiler. It still has this warning. Is it a good idea to create an issue for it?
run /var/www/html/qooxdoo/known-good/node_modules/.bin/qx compile --target=build
(node:39891) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
|
No, that problem should go away after this is released, known-good will automatically become a version with this fix in it. (I think it's automatic anyway! If not we'll just have to update a target version, but can't do that until after this is released) |
hkollmann
approved these changes
Apr 2, 2024
cboulanger
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The punycode warning is caused by old octokit and node-fetch; both are upgraded
Also this fixes #10669