-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qx.data.marshal.Json | ignore non-pojo objects when marshalling #10702
base: master
Are you sure you want to change the base?
Changes from 1 commit
1fac2e9
0f0e5de
29b4bef
4f78ec0
58de80e
c126c36
66de63d
90e7188
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,15 +52,23 @@ qx.Bootstrap.define("qx.lang.Type", { | |
isArray: qx.Bootstrap.isArray, | ||
|
||
/** | ||
* Whether the value is an object. Note that built-in types like Window are | ||
* not reported to be objects. | ||
* Whether the value is an object i.e. Object.prototype is its prototype or Object.prototype is in its prototype chain. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it would be helpful to explain the net effect - eg: "Objects can be either a POJO (ie |
||
* Note that built-in types like Window are not reported to be objects. | ||
* | ||
* @signature function(value) | ||
* @param value {var} Value to check. | ||
* @param {*} value value to check. | ||
* @return {Boolean} Whether the value is an object. | ||
*/ | ||
isObject: qx.Bootstrap.isObject, | ||
|
||
/** | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, the net effect is more useful in documentation than repeating the code, eg "Detects whether an object is just a plain POJO, ie |
||
* Whether the value is strictly a POJO. It's prototype must not inherit from Object.prototype but be strictly Object.prototype. | ||
* @signature function(value) | ||
* @param {*} value | ||
* @returns {Boolean} Whether the value is strictly a POJO. | ||
*/ | ||
isPojo: qx.Bootstrap.isPojo, | ||
|
||
/** | ||
* Whether the value is a function. | ||
* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isPojo
does not need to be inqx.Bootstrap
, which is effectively an internal class that exists in order to work around dependency management issues - IMHO it should move toqx.lang.Type