[RFC] Issue #9104 Provide dialog widgets #9111

yybalam · 2016-07-23T01:54:00Z

This PR try to provide to qooxdoo a default basic dialog widgets. Basically this PR add :

A Message dialog for alert messaged.
A Confirm dialog with support for attach function to buttons.
A BusyIndicator.

A qx.ui.Dialog static class provide a short way for launch dialogs.:

qx.ui.Dialog.alert("Yay, some dialog!");
qx.ui.Dialog.error("Some was wrong. :(");

Also this PR include an MBusyBlocker mixin. This mixin extend MBlocker for provide an loading gif while the widget is blocked. Also is possible to show a custom text if allowBusyPopup is set to true.

Right now there is only two test, one for Message and another for Confirm.

Whats missing?

Well, some documentation of course. Also I thing a test for MBusyBlocker, but I don found a test for MBlocker so I'm not sure how to test it.

Also when I compile using 'Tango' icon theme, the icons are shown, but I can't get it work for Oxygen.

I know this PR actually is not complete (sorry) to be merge, but maybe heps to get the way.

Cheers.

Call to 'encodeURI' and 'decodeURI' instead of 'escape' and 'unescape' deprecated functions.

…sage and show an icon.

This dialog provide for a window with title, message, also an ok and cancel buttons. Also is possible to asign a custom function for ok button.

…custop funcctions and aspects (icons and labels).

Now the constructor is more simple. Now expext an optional array as third argument, this array can be so simple as an array of string with the names of supported buttons, or a object mapping the icon, label, callback and context, all of this optional. The inner logic for compose buttons also become more simpler.

Added a new `_applyContext` method for change the context globally for callbacks.

…e call to setter methods of properties, like `setCallback()`.

yybalam · 2016-08-03T22:28:07Z

Hello.

Here is a live demo: http://yybalam.net/qxlab/dialoglab/
Here is the code of the demo: https://gitlab.com/yybalam/dialoglab/tree/master

So, I will to write the docs for manual and examples to demobrower, also add support for the rest of themes and the squashing of my lot of commits (at moment I don't know how to do this last one, need to study 😅)

coveralls · 2016-08-04T00:51:56Z

Coverage increased (+0.004%) to 55.693% when pulling 36caac8 on yybalam:dialoglab into 121f145 on qooxdoo:master.

woprandi · 2016-08-05T06:53:48Z

@yybalam you can check how to squash commits here : https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits

oetiker · 2016-08-05T07:14:27Z

looking at the demo ... like the optics ... I wonder about the placement of the buttons ... I would have expected them to be right aligned.

Added a mixin that provide of a widget blocker with busy indicators suppoert. Added a new abstract class for build dialog windows and Message and Confirm implementations. This dialog windows support themable icon's, a caption and a message. The Confirm implementation also support custom function for callbacks.

This dialog provide for a window with title, message, also an ok and cancel buttons. Also is possible to asign a custom function for ok button. Added support for icon to Abstract dialog class. Implemented factory method for build button. Added support to locale for labels. Added support for title translations. Added support for dialog titles translations at spanish.

Refactored for implement construction of internal widgets by child control approach. Added test for Message class, also this test checks for Abstract dialog class factory methods. Improved test method's names. Now are more explicit about what test. Added test for Confirm dialog. Test all the ways of construction, also test the proper context for handlers. Removed static assets for Oxygen icons. Updated tests for implement calls to «getChildControl()».

coveralls · 2016-08-08T20:55:08Z

Coverage increased (+0.03%) to 55.72% when pulling 3697049 on yybalam:dialoglab into 121f145 on qooxdoo:master.

oetiker · 2016-08-08T21:03:40Z

framework/source/class/qx/bom/Cookie.js

@@ -62,7 +62,7 @@ qx.Bootstrap.define("qx.bom.Cookie",
        end = document.cookie.length;
      }

-      return decodeURI(document.cookie.substring(len, end));
+      return unescape(document.cookie.substring(len, end));
    },


why ? unescape is deprecated ... is this a rebase problem ?

Nope. That is fixed by another PR that is no merged yet, so I think this PR must avoid that change, so this PR don't break anything with actual sate of master. 😅

ah this is a revert to your own patch series ... you definitely need to squash these bevor we can merge ...

Yes. I'll try to do it right in my next try. Squash is absolutely something new for me. 😅

coveralls · 2016-08-11T01:24:58Z

Coverage increased (+0.04%) to 55.731% when pulling b9d47fd on yybalam:dialoglab into 121f145 on qooxdoo:master.

Since indigo is an extension of simple they share elements.

coveralls · 2016-08-11T20:08:48Z

Coverage increased (+0.003%) to 55.691% when pulling f4939a1 on yybalam:dialoglab into 121f145 on qooxdoo:master.

zaucker · 2016-08-31T06:13:43Z

Are the block and busy variants styled differently than the other dialogs on purpose in the demo? Title and min/max/close buttons on block/busy (extending qx.ui.window.Window() and not on the others (probably extending Popup)?

yybalam · 2016-08-31T16:54:18Z

Yeah. The idea behind bolck and busy is a mixin (MBusyBlocker) for any widget, so do not have any special style, is just for block a Widget and shown a centred gif or popup with a tiny gif and a label. I just used Windows for convenience in the demo.

zaucker · 2016-08-31T18:49:26Z

Thanks for the explanation, sounds good.

On Wed, 31 Aug 2016, Yeye Balam wrote:

Yeah. The idea behind bolck and busy is a mixin (MBusyBlocker) for any
widget, so do not have any special style, is just for block a Widget and
shown a centred gif or popup with a tiny gif and a label. I just used
Windows for convenience in the demo.

Oetiker+Partner AG tel: +41 62 775 9903 (direct)
Fritz Zaucker +41 62 775 9900 (switch board)
Aarweg 15 +41 79 675 0630 (mobile)
CH-4600 Olten fax: +41 62 775 9905
Schweiz web: www.oetiker.ch

cboulanger · 2017-09-05T14:09:47Z

Hello @yybalam, still interested in contributing a widget set to qooxdoo for the 6.0 release? This would require that you update the PR to the current master and address the remaining issues raised in the discussion. You could also contribute your widget set as a "contrib", which would require to change the top-level namespace. It would be great to have two different dialog widget sets as contribs, so people have a choice... If you're interested, let me know.

yybalam · 2017-09-07T14:58:09Z

@cboulanger Oh, yeah. I'm still interesed in contributing the widget. But instead of update this PR, can I close this PR and create a new one?

cboulanger · 2017-09-07T15:01:09Z

@yybalam Sure!

level420 · 2017-12-06T13:41:58Z

As @yybalam suggested: closing this PR.

cboulanger · 2017-12-06T16:25:02Z

@yybalam please consider creating a contrib based on a child controls. It would be great to have stylable dialogs, I don't think I will have the time to ever work on my own Dialog widget and add styleability. Publishing the contrib will be really easy with the new qx contrib CLI commands which I hope to finish soon.

Yeshua Rodas added 30 commits July 8, 2016 18:06

Fix qooxdoo#9090

324c599

Call to 'encodeURI' and 'decodeURI' instead of 'escape' and 'unescape' deprecated functions.

Added loading gif for a BusyIndicator and MBusyBlocker.

6425680

Added a popup for show a little gif and a caption as busy indicator.

5367980

Added a mixin that provide of a widget blocker with busy indicators.

cbe4ac1

Merge remote-tracking branch 'upstream/master'

68dcf8f

Merge branch 'master' into dialoglab

0da64f3

Added a new abstraact class for build dialog windows.

0a702c8

Added a very basic Alert dialog. This class allow set a title and mes…

6da4004

…sage and show an icon.

Added suport for title and message to Abstract dialog.

177407a

Refactored according to Abstract class.

7bb32d9

Added a Confirm class dialog.

d8bbad2

This dialog provide for a window with title, message, also an ok and cancel buttons. Also is possible to asign a custom function for ok button.

Added support for icon to Abstract dialog class.

011e19f

Implemented factory method for build button.

523aec0

Added setter method for icon on Abstract class.

0698bc6

Refactored Alert constructor and added support for default icons.

d391eb8

Added support for buttons combination. Also added support for handle …

553aece

…custop funcctions and aspects (icons and labels).

Added some inline documentation.

b7dd5aa

Renamed Alert to Message.

9d9eb08

Ensure call to '__composeAspects()' only if an aspects map is provided.

638b917

Added static class for shorthand calls od dialogs.

5a51f11

Updated call to Confirm class.

e848315

Fix callback calls. Also teh logic now is more simple.

3a07810

Added a new `_applyContext` method for change the context globally for callbacks.

Added return for dialog instance. With this is possible to concatenat…

0b448a5

…e call to setter methods of properties, like `setCallback()`.

Added support for provide an icon via constructor as fourth parameter.

01d15a8

Fix method call.

36c3135

Simplied factory static class.

da6a75f

Added support to locale for labels.

909b7ee

Added support for success dialog.

ad9d9a7

Fix translation call. Do not call translation for variables.

23b0655

Yeshua Rodas added 10 commits August 8, 2016 13:46

Little spanish translation fixes.

a792dde

Uniform code style.

c60626f

Restore Cookie class to upstream/master.

90aff38

Added to indigo theme support for dialog.

34a7267

Fix var names from title to caption

48ed687

Change default align of buttons to right.

a485cfe

Resolving conflict on rebase try.

3697049

oetiker reviewed Aug 8, 2016
View reviewed changes

Added to widgetbrowser a new Tab with dialog demostration.

b9d47fd

Added support to simple theme for dialog.

f4939a1

Since indigo is an extension of simple they share elements.

level420 added the enhancement New features, give me a PR!!! label Dec 2, 2016

level420 closed this Dec 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Issue #9104 Provide dialog widgets #9111

[RFC] Issue #9104 Provide dialog widgets #9111

yybalam commented Jul 23, 2016

yybalam commented Aug 3, 2016 •

edited

coveralls commented Aug 4, 2016

woprandi commented Aug 5, 2016

oetiker commented Aug 5, 2016

coveralls commented Aug 8, 2016

oetiker Aug 8, 2016 •

edited

yybalam Aug 8, 2016

oetiker Aug 8, 2016

yybalam Aug 8, 2016

coveralls commented Aug 11, 2016

coveralls commented Aug 11, 2016

zaucker commented Aug 31, 2016

yybalam commented Aug 31, 2016

zaucker commented Aug 31, 2016

cboulanger commented Sep 5, 2017

yybalam commented Sep 7, 2017

cboulanger commented Sep 7, 2017

level420 commented Dec 6, 2017

cboulanger commented Dec 6, 2017

[RFC] Issue #9104 Provide dialog widgets #9111

[RFC] Issue #9104 Provide dialog widgets #9111

Conversation

yybalam commented Jul 23, 2016

Whats missing?

yybalam commented Aug 3, 2016 • edited

coveralls commented Aug 4, 2016

woprandi commented Aug 5, 2016

oetiker commented Aug 5, 2016

coveralls commented Aug 8, 2016

oetiker Aug 8, 2016 • edited

Choose a reason for hiding this comment

yybalam Aug 8, 2016

Choose a reason for hiding this comment

oetiker Aug 8, 2016

Choose a reason for hiding this comment

yybalam Aug 8, 2016

Choose a reason for hiding this comment

coveralls commented Aug 11, 2016

coveralls commented Aug 11, 2016

zaucker commented Aug 31, 2016

yybalam commented Aug 31, 2016

zaucker commented Aug 31, 2016

cboulanger commented Sep 5, 2017

yybalam commented Sep 7, 2017

cboulanger commented Sep 7, 2017

level420 commented Dec 6, 2017

cboulanger commented Dec 6, 2017

yybalam commented Aug 3, 2016 •

edited

oetiker Aug 8, 2016 •

edited