Arrays

[johnspackman]

This PR synchronises qx.lang.Array and qx.data.Array and adds a new .replace() method

The intention is to remove clutter that can crop up when dealing with arrays, especially when you are not able to know in advance whether the array is a qx.data.Array or a native array; for example:

if (arr instanceof qx.data.Array)
  arr = arr.toArray();
if (otherArray instanceof qx.data.Array)
  otherArray = otherArray.toArray();
return qx.lang.Array.equals(arr, otherArray);

becomes:

return qx.lang.Array.equals(arr, anotherArray);

Similarly, qx.data.Array.append already supported native arrays as the source array, but other methods like .equals did not.

The .replace method is added because when editing a qx.data.Array it is often desirable to avoid multiple change events caused by adding and removing multiple entries; it's easy to achieve this is by splice-ing in a new array, but it's clunky code that should be kept out of the application.

Also missing unit tests for some methods

[coveralls]

Coverage increased (+0.04%) to 55.733% when pulling 79e601c on johnspackman:arrays into 0a763db on qooxdoo:master.

[coveralls]

Coverage increased (+0.05%) to 55.735% when pulling 9d00203 on johnspackman:arrays into 0a763db on qooxdoo:master.

[level420]

LGTM

[cajus]

☑️ CALL FOR VOTES

[coveralls]

Coverage increased (+0.05%) to 55.735% when pulling 1bd5628 on johnspackman:arrays into 0a763db on qooxdoo:master.

[cajus]

Two business days have passed. No vote against.