Add method getSubcontrolId returning the id used in _createChildControlImpl #9140
Conversation
| @@ -3687,6 +3687,19 @@ qx.Class.define("qx.ui.core.Widget", | |||
| }, | |||
|
|
|||
|
|
|||
| /** | |||
| * Return the ID of the current widget if it is a created as a | |||
There was a problem hiding this comment.
If the widget has been created as a ChildControl, this will return the name of the ChildControl.
There was a problem hiding this comment.
yes. But the name is called id in e.g. _createChildControlImpl https://github.com/qooxdoo/qooxdoo/blob/master/framework/source/class/qx/ui/core/Widget.js#L3629
So I thought it's the right naming
There was a problem hiding this comment.
OK, then this:
If the widget has been created as a ChildControl, return the ID (name) of the ChildControl.
the problem is that your current sentence does not really work ... it is missing words.
There was a problem hiding this comment.
OK then It's my bad english. Will try to do it better.
|
much better |
|
☑️ CALL FOR VOTES |
|
How do I vote? LGTM |
|
@voger Sorry, voting is only possible for the core-team members. |
|
Oh I didn't know that. Still looks good. :) |
This allows, e.g. while listening to the createChildControl event, retrieval of the used id during child control creation.