Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first attempt at getting old builds back #9562

Merged
merged 4 commits into from Aug 22, 2018
Merged

first attempt at getting old builds back #9562

merged 4 commits into from Aug 22, 2018

Conversation

oetiker
Copy link
Member

@oetiker oetiker commented Aug 21, 2018

No description provided.

derrell
derrell previously approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@derrell derrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about this stuff, so I'll approve so I don't hold up the process.

cboulanger
cboulanger previously approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@cboulanger cboulanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My knowledge of the testing workflow is almost zero, but I welcome any attempt to make it work again.

hkollmann
hkollmann previously approved these changes Aug 21, 2018
View reviewed changes
johnspackman
johnspackman previously approved these changes Aug 21, 2018
View reviewed changes
@hkollmann
Copy link
Member

I think this needs a direct commit. During PR test should run…
This is the cat biting it's tail

level420
level420 previously approved these changes Aug 22, 2018
View reviewed changes
@oetiker
Copy link
Member Author

oetiker commented Aug 22, 2018

hmmm why does this beast no see that travis is happy ?

@oetiker oetiker merged commit 6606c75 into qooxdoo:master Aug 22, 2018
@oetiker oetiker deleted the desauce-travis-pr branch August 22, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboulanger cboulanger cboulanger approved these changes

@johnspackman johnspackman johnspackman approved these changes

@level420 level420 level420 approved these changes

@derrell derrell derrell approved these changes

@cajus cajus Awaiting requested review from cajus

@hkollmann hkollmann Awaiting requested review from hkollmann hkollmann is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@oetiker @hkollmann @cboulanger @johnspackman @level420 @derrell