Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to fix disappearing $ signs #9872

Closed
wants to merge 2 commits into from
Closed

try to fix disappearing $ signs #9872

wants to merge 2 commits into from

Conversation

oetiker
Copy link
Member

@oetiker oetiker commented Feb 28, 2020 •
edited by level420

No description provided.

@pullapprove pullapprove bot removed the request for review from level420 February 28, 2020 10:13
@pullapprove pullapprove bot requested a review from zaucker February 28, 2020 10:14
level420
level420 reviewed Feb 28, 2020
View reviewed changes
Copy link
Member

@level420 level420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do the $ signs disappear? from what i can see they are perfectly displayed when watching the doc in the browser: https://github.com/qooxdoo/qooxdoo/blob/master/docs/compiler/internals/CustomAppStartup.md

@level420
Copy link
Member

sorry accidentally edited the PR description :-(
@oetiker please restore it if possible

hkollmann
hkollmann requested changes Feb 28, 2020
View reviewed changes
docs/compiler/internals/CustomAppStartup.md
@@ -72,8 +72,8 @@ Here's a complete, although minimal, example of an index.html:
<title>${appTitle}</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should'nt this masked too?

@oetiker
Copy link
Member Author

oetiker commented Feb 28, 2020

they do not show up in the documentation website ... but you are right the fix is probably elsewhere.

@oetiker oetiker closed this Feb 28, 2020
@hkollmann hkollmann deleted the oetiker-patch-1 branch March 10, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@level420 level420 level420 left review comments

@hkollmann hkollmann hkollmann requested changes

@cboulanger cboulanger cboulanger approved these changes

@derrell derrell Awaiting requested review from derrell derrell is a code owner

@johnspackman johnspackman Awaiting requested review from johnspackman johnspackman is a code owner

@lucapivato lucapivato Awaiting requested review from lucapivato lucapivato is a code owner

@zaucker zaucker Awaiting requested review from zaucker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oetiker @level420 @cboulanger @hkollmann