TreeVirtual NodeEdit - Fix for old/new node label is the same in dataEdited #9999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rad-pat
requested review from
cboulanger,
derrell,
hkollmann,
johnspackman,
level420,
lucapivato and
oetiker
as code owners
cboulanger
approved these changes
Jun 2, 2020
level420
approved these changes
Jun 2, 2020
derrell
approved these changes
Jun 2, 2020
zaucker
approved these changes
Jun 2, 2020
hkollmann
approved these changes
Jun 2, 2020
oetiker
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the dataEdited event is fired, the old and new values refer to the same object, albeit with the label updated. If the node object is replaced with a clone with the updated label, the old and new values are as expected.