Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Incubators #5

Merged
merged 1 commit into from Sep 11, 2019
Merged

add Incubators #5

merged 1 commit into from Sep 11, 2019

Conversation

johnspackman
Copy link
Member

No description provided.

@johnspackman johnspackman mentioned this pull request Sep 11, 2019
Closed
cboulanger
cboulanger approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@cboulanger cboulanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but I would skip the "Use case part" since this is the manual, which should be purely normative. We already had the discussion on the merits of this proposal and decided that it should be implemented.

@cboulanger cboulanger merged commit b40a89c into qooxdoo:master Sep 11, 2019
@cboulanger
Copy link
Contributor

Full approval, merged. Thank you, @johnspackman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboulanger cboulanger cboulanger approved these changes

@level420 level420 level420 approved these changes

@derrell derrell derrell approved these changes

@oetiker oetiker oetiker approved these changes

@hkollmann hkollmann hkollmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@johnspackman @cboulanger @level420 @derrell @oetiker @hkollmann