Fix errors 1170 and 1071, and support UTF8 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error 1170: BLOB/TEXT column 'key' used in key specification without a key length Fix error 1071: Specified key was too long; max key length is 767 bytes Support UTF8 (three bytes per character)
|
Hi @joelchen We don't want to only support 255 length translation keys, but do want to support text, although the warning message is boring, you could safe to ignore it, it will only just a little of slower when updating translations. Will check it later to remove the warning the message totally. Thank you for your PR anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error 1170: BLOB/TEXT column 'key' used in key specification without a key length
Fix error 1071: Specified key was too long; max key length is 767 bytes
Support UTF8 (three bytes per character)