improve QUnit assertion failure output to include more stack information to cover the case when multiple test modules are used #1720
Comments
or maybe just to show the whole stack trace for all assertion failures - assertion failures should not happen anyway (what I mean by this is that tests are supposed to pass, if they fail, then as much info as possible should be shown) |
@omusil24 I assigned this to Jan because I assume you're not working on it, and he's interested in fixing it - if it's a problem let me know - my fault, not Jan's :) |
No, it's ok. I have looked at it only briefly before I left so no problem. |
needs an additional modification to address situations like:
the |
davidnich
added a commit
that referenced
this issue
Jan 2, 2018
pvanek
added a commit
that referenced
this issue
Jan 3, 2018
…_fix refs #1720 additional fixes to QUnit stack trace location output
davidnich
added a commit
that referenced
this issue
Jan 4, 2018
…s present), then the function context (if present); show in "depth-first" order (most recent calls first) to give more accurate location reporting first
pvanek
added a commit
that referenced
this issue
Jan 4, 2018
…_fix refs #1720 final (hopefully) 1720 fix; show the location first (alway…
davidnich
added a commit
that referenced
this issue
Jan 6, 2018
pvanek
added a commit
that referenced
this issue
Jan 6, 2018
refs #1720 fixed exception location info (again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
QUnit currently reports the last non-module location in an assertion, however the actual error could have been in a module (or QUnit itself); more stack information would be useful
Possibly the best solution would be to display a full stack trace with verbose >= 1
The text was updated successfully, but these errors were encountered: