New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve QUnit assertion failure output to include more stack information to cover the case when multiple test modules are used #1720

Closed
davidnich opened this Issue Feb 26, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@davidnich
Contributor

davidnich commented Feb 26, 2017

QUnit currently reports the last non-module location in an assertion, however the actual error could have been in a module (or QUnit itself); more stack information would be useful

Possibly the best solution would be to display a full stack trace with verbose >= 1

@davidnich davidnich added this to the 0.8.13 milestone Feb 26, 2017

@davidnich davidnich changed the title from improve assertion failure output to include more stack information to cover the case when multiple test modules are used to improve QUnit assertion failure output to include more stack information to cover the case when multiple test modules are used Feb 26, 2017

@davidnich davidnich removed the module label Feb 26, 2017

@davidnich

This comment has been minimized.

Contributor

davidnich commented Feb 27, 2017

or maybe just to show the whole stack trace for all assertion failures - assertion failures should not happen anyway (what I mean by this is that tests are supposed to pass, if they fail, then as much info as possible should be shown)

@omusil24 omusil24 self-assigned this Aug 18, 2017

@davidnich davidnich modified the milestones: 0.8.13, 0.8.13.1 Sep 30, 2017

@davidnich davidnich assigned galvani and unassigned omusil24 Oct 23, 2017

@davidnich

This comment has been minimized.

Contributor

davidnich commented Oct 23, 2017

@omusil24 I assigned this to Jan because I assume you're not working on it, and he's interested in fixing it - if it's a problem let me know - my fault, not Jan's :)

@omusil24

This comment has been minimized.

Contributor

omusil24 commented Oct 23, 2017

No, it's ok. I have looked at it only briefly before I left so no problem.

@davidnich davidnich modified the milestones: 0.8.13.1, 0.8.13.2 Dec 18, 2017

davidnich added a commit that referenced this issue Jan 1, 2018

pvanek added a commit that referenced this issue Jan 2, 2018

@omusil24 omusil24 added the fixed label Jan 2, 2018

@omusil24 omusil24 closed this Jan 2, 2018

@davidnich davidnich removed the fixed label Jan 2, 2018

@davidnich

This comment has been minimized.

Contributor

davidnich commented Jan 2, 2018

needs an additional modification to address situations like:

+ OK: "REGRESSION-TEST" assertion in <start> :-1 -> QorusRegression::constructor() at ./QorusRegression.qtest:376 -> QorusRegression::rpcTest() at ./QorusRegression.qtest:1560

the <start> :-1 should not be there as it doesn't provide any value

@davidnich davidnich reopened this Jan 2, 2018

davidnich added a commit that referenced this issue Jan 2, 2018

pvanek added a commit that referenced this issue Jan 3, 2018

Merge pull request #2586 from qorelanguage/bugfix/1720_QUnit_location…
…_fix

refs #1720 additional fixes to QUnit stack trace location output

davidnich added a commit that referenced this issue Jan 4, 2018

refs #1720 final (hopefully) 1720 fix; show the location first (alway…
…s present), then the function context (if present); show in "depth-first" order (most recent calls first) to give more accurate location reporting first

pvanek added a commit that referenced this issue Jan 4, 2018

Merge pull request #2588 from qorelanguage/bugfix/1720_QUnit_location…
…_fix

refs #1720 final (hopefully) 1720 fix; show the location first (alway…

davidnich added a commit that referenced this issue Jan 6, 2018

pvanek added a commit that referenced this issue Jan 6, 2018

Merge pull request #2593 from qorelanguage/bugfix/1720_QUnit_fix
refs #1720 fixed exception location info (again)

@davidnich davidnich added the fixed label Jan 6, 2018

@davidnich davidnich closed this Jan 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment