Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestHandler returns 409 instead of 404 when child class/resource is missing #2405

Closed
omusil24 opened this issue Nov 9, 2017 · 1 comment
Closed

RestHandler returns 409 instead of 404 when child class/resource is missing #2405

omusil24 opened this issue Nov 9, 2017 · 1 comment
Assignees
@davidnich
Labels
bug fixed not-c++
Milestone
0.8.13.1

Comments

@omusil24
Copy link

omusil24 commented Nov 9, 2017 

GET /api/passenger/blablabla HTTP/1.1
> hash: (6 members)
  Accept : "text/x-yaml,application/x-yaml,text/xml,application/xml,application/json,application/x-www-form-urlencoded,text/plain"
  User-Agent : "Qore-RestClient/1.4"
  Accept-Encoding : "deflate,gzip,bzip2"
  Connection : "Keep-Alive"
  Host : "localhost:8200"
< HTTP/1.1 409 Conflict
< hash: (8 members)
  http_version : "1.1"
  status_code : 409
  status_message : "Conflict"
  server : "Qorus-HTTP-Server/0.3.11.1"
  x-powered-by : "Qore/0.8.13.1"
  connection : "Keep-Alive"
  content-type : "application/json;charset=utf8"
  content-length : "610"
User exception: /usr/share/qore-modules/0.8.13/RestClient.qm:873: REST-CLASS-ERROR: class "passenger" has no subclass "blablabla"
@omusil24 omusil24 added this to the 0.8.13.1 milestone Nov 9, 2017
omusil24 pushed a commit that referenced this issue Nov 9, 2017
Added test for issue #2405
51c4dcb
davidnich added a commit that referenced this issue Nov 9, 2017
@davidnich
Merge pull request #2406 from qorelanguage/bugfix/2405_resthandler_40…
e5e41ea 
…9_response

Fixed #2405 incorrect response code in RestHandler.qm returned when REST subclass does not exist
@omusil24 omusil24 added the fixed label Nov 10, 2017
@davidnich davidnich removed the fixed label Nov 15, 2017
@davidnich
Copy link
Contributor

fix was not complete

@davidnich davidnich reopened this Nov 15, 2017
davidnich added a commit that referenced this issue Nov 15, 2017
@davidnich
refs #2405 better missing REST class fix
2d5e63b
davidnich added a commit that referenced this issue Nov 15, 2017
@davidnich
refs #2405 even better fix; behavior follows docs - unknownSubClassEr…
c39edf0 
…ror() is called when the class cannot be matched
pvanek added a commit that referenced this issue Nov 15, 2017
@pvanek
Merge pull request #2446 from qorelanguage/bugfix/2405_404_fix
bbf61d5 
refs #2405 better missing REST class fix
@omusil24 omusil24 added the fixed label Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidnich davidnich

Labels
bug fixed not-c++
Projects
None yet
Milestone
0.8.13.1
Development

No branches or pull requests
2 participants
@davidnich @omusil24