Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpServer unnecessarily masks unsensitive data in logs #2621

Closed
omusil24 opened this issue Jan 24, 2018 · 0 comments
Closed

HttpServer unnecessarily masks unsensitive data in logs #2621

omusil24 opened this issue Jan 24, 2018 · 0 comments
Assignees
@davidnich
Labels
bug fixed not-c++
Milestone
0.8.13.3

Comments

@omusil24
Copy link

HttpServer masks even unsensitive data in logs. It's enough that there's a word containing "pass" and it gets masked. This happens for example with "passenger" which makes logs less useful because for example full HTTP call address is "lost".
@omusil24 omusil24 added the bug label Jan 24, 2018
@omusil24 omusil24 added this to the 0.8.13.3 milestone Jan 24, 2018
davidnich added a commit that referenced this issue Jan 25, 2018
@davidnich
refs #2621 adjusted the http_mask_data() function in HttpServerUtil t…
172b7be 
…o mask fewer false positives, added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidnich davidnich

Labels
bug fixed not-c++
Projects
None yet
Milestone
0.8.13.3
Development

No branches or pull requests
2 participants
@davidnich @omusil24