Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove <run-time-loaded: label> from Program::parseXXX() #2903

Closed
tmandys opened this issue Jul 17, 2018 · 0 comments
Closed

Remove <run-time-loaded: label> from Program::parseXXX() #2903

tmandys opened this issue Jul 17, 2018 · 0 comments
Assignees
@tmandys
Labels
c++ feature
Milestone
0.9

Comments

@tmandys
Copy link
Contributor

tmandys commented Jul 17, 2018

Parse method add human readable string to the label. But the label is indexed and used by debugger to resolve source code. It is controlled via format_label with default value True. There is no use case for it. So format_label become as obsolete.

do you think we could break backward compatibility and remove artificial <run-time-loaded: %s> text completely ? I originally planned to support both names but it is rather messes the code. And if never used ....

<run-time-loaded: master_data_item_cost_bi_generate_report>:79 (source "mip01a_master_data_item_cost_bi_generate_report-v1.0.qfd":85)
@tmandys tmandys added this to the 0.8.13.7 milestone Jul 17, 2018
@tmandys tmandys self-assigned this Jul 17, 2018
tmandys added a commit that referenced this issue Jul 18, 2018
@tmandys
refs #2903 remove <run-time-loaded: label> from Program::parseXXX(), …
03169e5 
…format_label is obsolete
tmandys added a commit that referenced this issue Aug 23, 2018
@tmandys
refs #2903 remove <run-time-loaded: label> from Program::parseXXX(), …
43632b1 
…format_label is obsolete
@tmandys tmandys modified the milestones: 0.8.13.7, 0.9 Aug 23, 2018
sejvlond pushed a commit that referenced this issue Sep 18, 2018
@tmandys @sejvlond
Feature/2903 devel program parse runtimeloaded (#2959)
74421c4 
* refs #2903 remove <run-time-loaded: label> from Program::parseXXX(), format_label is obsolete
@tmandys tmandys closed this as completed Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmandys tmandys

Labels
c++ feature
Projects
None yet
Milestone
0.9
Development

No branches or pull requests
1 participant
@tmandys