Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Qore/QT account for setting statuses in Gitlabfiles #4160

Open
omusil24 opened this issue Jan 23, 2021 · 0 comments
Open

Use Qore/QT account for setting statuses in Gitlabfiles #4160

omusil24 opened this issue Jan 23, 2021 · 0 comments
Assignees

Comments

@omusil24
Copy link

Most Gitlabfiles of Qore and modules still contain the following type of code:

curl "https://api.github.com/repos/qorelanguage/${REPO_NAME}/statuses/${CI_COMMIT_SHA}" \
        -X POST -u omusil24:${GITHUB_ACCESS_TOKEN} -H "Content-Type: application/json" \
        -d "{\"state\": \"pending\", \"context\": \"${REPO_NAME}\", \"description\": \"Gitlab CI\", \"target_url\": \"${CI_JOB_URL}\"}"

which is using my Github account and token. I'm not gonna remove it or anything, but I think this should be changed to use some kind of Qore/QT Github account. Ideally also modified to use a var like ${GITHUB_USER} which can be set in project pipelines in Gitlab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants