Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module-jni: dynamic imports in Java do not support importing code types correctly as QoreClosureMarkerImpl #4593

Closed
davidnich opened this issue Oct 2, 2022 · 0 comments

Comments

@davidnich
Copy link
Contributor

davidnich commented Oct 2, 2022

code: private abstract submitImpl(code enqueue, auto _data); is imported as protected abstract submitImpl(Object enqueue, Object _data); whereas it should be: protected abstract submitImpl(org.qore.jni.QoreClosureMarkerImpl enqueue, Object _data);

err:

Issue3485JavaProcessor1.java:13: error: Issue3485JavaProcessor1 is not abstract and does not override abstract method submitImpl(Object,Object) in AbstractDataProcessor
class Issue3485JavaProcessor1 extends AbstractDataProcessor {
^
1 error
"/home/david/src/Qorus/git/qorus-ce/test/issue-3485/Issue3485JavaProcessor1-1.0.qclass.yaml": QoreJavaCompiler.java:354 (Java): JNI-ERROR: org.qore.jni.compiler.QoreJavaCompilerException: Compilation failed.
call stack:
  org.qore.jni.compiler.QoreJavaCompiler.compile() called at NativeMethodAccessorImpl.java:-2 (Java) (builtin function)
  jdk.internal.reflect.NativeMethodAccessorImpl.invoke0() called at NativeMethodAccessorImpl.java:77 (Java) (user function)
  jdk.internal.reflect.NativeMethodAccessorImpl.invoke() called at DelegatingMethodAccessorImpl.java:43 (Java) (user function)
  jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke() called at Method.java:568 (Java) (user function)
  java.lang.reflect.Method.invoke() called at QoreJavaDynamicApi.java:55 (Java) (user function)
  org.qore.jni.QoreJavaDynamicApi.invokeMethod() called at defs.cpp:72 (c++) (builtin function)
  QoreJavaCompiler::compile() called at /home/david/src/Qorus/current-ce/qlib/QorusClientBase.qm:11516 (Qore) (builtin function)
  QorusProgram::javaCompile() called at /home/david/src/Qorus/current-ce/bin/oload:12394 (Qore) (user function)
  JavaClassHelper::compileJavaSourceIntern() called at /home/david/src/Qorus/current-ce/bin/oload:12281 (Qore) (user function)
  JavaClassHelper::compileJavaSource() called at /home/david/src/Qorus/current-ce/bin/oload:12021 (Qore) (user function)
  ClassDbInserter::write() called at /home/david/src/Qorus/current-ce/bin/oload:11994 (Qore) (user function)
  ClassDbInserter::insertImpl() called at /home/david/src/Qorus/current-ce/bin/oload:10919 (Qore) (user function)
  DbInserter::insert() called at /home/david/src/Qorus/current-ce/bin/oload:10909 (Qore) (user function)
  DbInserter::insertObjects() called at /home/david/src/Qorus/current-ce/bin/oload:1990 (Qore) (user function)
  oload::insertObjectsFromYaml() called at /home/david/src/Qorus/current-ce/bin/oload:2017 (Qore) (user function)
  oload::createObjectsFromYaml() called at /home/david/src/Qorus/current-ce/bin/oload:772 (Qore) (user function)
  oload::constructor() called at <builtin>:-1 (Qore) (user function)
@davidnich davidnich added this to the 1.12.0 milestone Oct 2, 2022
@davidnich davidnich self-assigned this Oct 2, 2022
@davidnich davidnich added this to To do in Qore Development via automation Oct 2, 2022
davidnich added a commit to qorelanguage/module-jni that referenced this issue Oct 2, 2022
@davidnich davidnich added the fixed label Oct 2, 2022
Qore Development automation moved this from To do to Done Oct 2, 2022
davidnich added a commit to qorelanguage/module-jni that referenced this issue Oct 2, 2022
… break backwards compatbility with ewxisting working code
@davidnich davidnich changed the title module-jni: dynamic imports in Java do not support importing code types correctly as QoreClosure module-jni: dynamic imports in Java do not support importing code types correctly as QoreClosureMarkerImpl Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant