Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestHandler: responses to request errors cannot be enriched with additional headers (ex: CORS headers) by child classes #4646

Closed
davidnich opened this issue Nov 24, 2022 · 0 comments
Closed

RestHandler: responses to request errors cannot be enriched with additional headers (ex: CORS headers) by child classes #4646

davidnich opened this issue Nov 24, 2022 · 0 comments
Assignees
@davidnich
Labels
bug confusing fixed not-c++
Projects
Qore Development
Milestone
1.12.3

Comments

@davidnich
Copy link
Contributor

this can lead to misleading and hard to debug situations, particularly when the missing headers are CORS headers
@davidnich davidnich added this to the 1.12.3 milestone Nov 24, 2022
@davidnich davidnich added this to To do in Qore Development via automation Nov 24, 2022
@davidnich davidnich self-assigned this Nov 24, 2022
davidnich added a commit that referenced this issue Nov 24, 2022
@davidnich
refs #4646 allow REST handlers to set custom headers in error responses
8463c9a 
refs #4647 ensure that deserialization errors in requests result in a 400 Bad Request response
davidnich added a commit that referenced this issue Nov 24, 2022
@davidnich
refs #4646 allow REST handlers to set custom headers in error respons…
31cea35 
…es (#4648)

refs #4647 ensure that deserialization errors in requests result in a 400 Bad Request response
Qore Development automation moved this from To do to Done Nov 24, 2022
davidnich added a commit that referenced this issue Nov 24, 2022
@davidnich
refs #4646 fix for the last commit
c8956b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidnich davidnich

Labels
bug confusing fixed not-c++
Projects
Qore Development
Done
Milestone
1.12.3
Development

No branches or pull requests
1 participant
@davidnich