Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 implementation inconsistent in RestClient hierarchy #4766

Closed
davidnich opened this issue Aug 20, 2023 · 0 comments
Closed

OAuth2 implementation inconsistent in RestClient hierarchy #4766

davidnich opened this issue Aug 20, 2023 · 0 comments
Assignees
@davidnich
Labels
bug fixed not-c++
Projects
Qore Development
Milestone
1.19.0

Comments

@davidnich
Copy link
Contributor

it's implemented ad-hoc in connections that use it rather than generically in the base class
@davidnich davidnich added this to the 1.18.2 milestone Aug 20, 2023
@davidnich davidnich self-assigned this Aug 20, 2023
@davidnich davidnich added this to To do in Qore Development via automation Aug 20, 2023
davidnich added a commit that referenced this issue Aug 20, 2023
@davidnich
refs #4766 start of generic OAuth2 implementation in the RestClient m…
9d8fc30 
…odule
davidnich added a commit that referenced this issue Aug 23, 2023
@davidnich
refs #4766 fixed REST polling ping with non-blocking I/O
b7c834d
davidnich added a commit that referenced this issue Aug 23, 2023
@davidnich
refs #4766 added missing file
63c40bb
davidnich added a commit that referenced this issue Aug 23, 2023
@davidnich
refs #4766 fixed a deadlock introduced in the last commits
7b1bf75
davidnich added a commit that referenced this issue Aug 23, 2023
@davidnich
Feature/4766 rest client poll fixes (#4767)
3fe8e85 
* refs #4766 fixed REST polling ping with non-blocking I/O
Qore Development automation moved this from To do to Done Aug 23, 2023
davidnich added a commit that referenced this issue Aug 24, 2023
@davidnich
refs #4766 non-blocking File I/O fixes, improved tests
9e6dae4
davidnich added a commit that referenced this issue Aug 25, 2023
@davidnich
refs #4766 updated RestClient modules for OAuth2 changes; minor rest …
3e57721 
…script fixes when used with connections
davidnich added a commit that referenced this issue Aug 25, 2023
@davidnich
refs #4766 RestClient polling improvements and fixes, tests for Servi…
7c91437 
…ceNow and Salesforce REST polling, inline & non-blocking, other minor fixes and improvements
davidnich added a commit that referenced this issue Sep 1, 2023
@davidnich
refs #4766 added a refresh token option to the RestClient
d624f82
davidnich added a commit that referenced this issue Sep 2, 2023
@davidnich
refs #4766 implemented additional OAuth2 options + tests
726c6d8
davidnich added a commit that referenced this issue Sep 5, 2023
@davidnich
refs #4766 minor fixes and updates
29e141e
davidnich added a commit that referenced this issue Sep 10, 2023
@davidnich
refs #4773 fixed GoogleRestClient option handling
1b3cbed 
refs #4766 implemented support for auto as the default oauth2_redirect_url value
return connection options sorted by option name to provide a better UX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidnich davidnich

Labels
bug fixed not-c++
Projects
Qore Development
Done
Milestone
1.19.0
Development

No branches or pull requests
1 participant
@davidnich