refs #1736 fixed a bug in processing "list mode" data in the Mapper c… #1737

davidnich · 2017-03-03T18:08:00Z

…lass such as submitted from InboundTableMapper::queueData(hash of lists); this bug was introduced in Qore 0.8.12.7 with the fix for refs #1626

…lass such as submitted from InboundTableMapper::queueData(hash of lists); this bug was introduced in Qore 0.8.12.6 with the fix for refs #1620

…ing optimized hashes of lists and constant values

…xed lists and single values and to throw a runtime exception if lists of different sizes are encountered instead of silently ignoring the data refs #1736 updated the TableMapper class to use the original, must more efficient implementation of iterating hash of list data with <hash>::contextIterator() added tests + relnotes

davidnich · 2017-03-04T06:04:53Z

@pavelkveton the implementation has been improved with a fix for #1738

the return value of TableMapper::queueData() and TableMapper::flush() can once again be safely iterated with <hash>::contextIterator() (HashListIterator); the "edge-case-breakage" caused by this issue (which was found while fixing InboundTableMapper::queueData() error with hashes of lists #1736) is one of the main motivations for fixing HashListIterator fails to iterate hash keys with single values #1738 and including it in this pull request
data errors with lists of different sizes are no longer silently ignored by HashListIterator
TableMapper performance with bulk DML and and output log and/or a rowcode value will remain the same vs the alternative of not fixing HashListIterator fails to iterate hash keys with single values #1738 and re-writing hash of lists iteration in Qore to handle constant values - all such cases would need to be identified and worked around, which would be potentially dangerous

…r::flush() with <hash>::contextIterator()

refs #1736 fixed a bug in processing "list mode" data in the Mapper c…

b9a1606

…lass such as submitted from InboundTableMapper::queueData(hash of lists); this bug was introduced in Qore 0.8.12.6 with the fix for refs #1620

davidnich assigned pavelkveton and unassigned pavelkveton Mar 3, 2017

davidnich added 4 commits March 3, 2017 20:08

refs #1736 added additional fixes and tests for compatibility with us…

7d805de

…ing optimized hashes of lists and constant values

refs #1736 added an additional release note

94387f3

refs #1736 fixed determining the list size

6cb9a8e

davidnich added 3 commits March 4, 2017 07:13

refs #1738 added tests for corner cases, added docs

fb8dadb

refs #1738 improved documentation

4fdce47

refs #1738 re-added test of iterating the output of InboundTableMappe…

247e77d

…r::flush() with <hash>::contextIterator()

davidnich assigned pavelkveton Mar 4, 2017

pavelkveton approved these changes Mar 6, 2017

View reviewed changes

pavelkveton merged commit 3ebd0d4 into 0.8.12 Mar 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refs #1736 fixed a bug in processing "list mode" data in the Mapper c… #1737

refs #1736 fixed a bug in processing "list mode" data in the Mapper c… #1737

davidnich commented Mar 3, 2017 •

edited

davidnich commented Mar 4, 2017 •

edited

refs #1736 fixed a bug in processing "list mode" data in the Mapper c… #1737

refs #1736 fixed a bug in processing "list mode" data in the Mapper c… #1737

Conversation

davidnich commented Mar 3, 2017 • edited

davidnich commented Mar 4, 2017 • edited

davidnich commented Mar 3, 2017 •

edited

davidnich commented Mar 4, 2017 •

edited