This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
Xmpp Appender #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please send a signed copy of the CLA to ceki@qos.ch. |
| @@ -0,0 +1,143 @@ | |||
| package ch.qos.logback.classic.net; | |||
There was a problem hiding this comment.
Please fix the following issues:
- Use 4-space tabs
- Add standard file header
|
It looks like @m-szalik has submitted a signed CLA already |
| boolean doStop = isStarted(); | ||
| super.stop(); | ||
| if (doStop) { | ||
| if (conn != null && conn.isConnected()) { |
| } | ||
|
|
||
| @Test | ||
| public void testAppendOff() throws Exception { |
There was a problem hiding this comment.
There was a problem hiding this comment.
This end-to-end test tests real solution. The test requires XMPP server and the result is visible on real xmpp account.
That is why there is no assert.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xmpp Appender allows to send logging events to Google hangout, Jabber and all chats compatible with xmpp.