Move DBAppender SQL scripts from src/main/java to src/main/resources #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… src/main/resources
… the SyslogOutputStream is null (due to a host lookup failure for example)
…ncy and fix a couple typos
LOGBACK-960 Prevent a possible NPE in SyslogAppenderBase.close()
|
There appears to be a merge conflict. Can you please rebase this? Thanks! |
|
Also please update the release notes to indicate your change. |
Fix LOGBACK-268 by using a fair ReentrantLock (instead of object synchronization).
LOGBACK-268 - Fair locking in OutputStreamAppender
Use an abstract method to create the SyslogOutputStream that subclasses can override
Added a file to describe general guidelines for submitting pull requests.
src/main/resources
Conflicts: logback-access/src/main/resources/ch/qos/logback/access/db/script/mysql.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting those scripts in logback jars allows to use them while testing your code with an in-memory database like this:
jdbc:h2:mem:test;DB_CLOSE_DELAY=-1;INIT=RUNSCRIPT FROM 'classpath:ch/qos/logback/classic/db/script/h2.sql'