LOGBACK-1728: Incorrect OSGi execution-environment requirements #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the explicitly specified, but out dated, 'Bundle-RequiredExecutionEnvironment: JavaSE-1.6' entry and let the maven-bundle-plugin instead add a automatically computed ee-requirement (therefore remove the '_noee' instruction). This ensures the OSGi-ExecutionEnvironment metadata are always up to date. Remove all other explicitly configuration that can be derived automatically and is not necessary, like more Import-Package values or '_failok'. Some of the explicitly imported packages are not even referenced in the code. Fixes https://jira.qos.ch/browse/LOGBACK-1728 Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
HannesWell
force-pushed
the
osgiEEConfig
branch
from
db09d65
to
f07c922
Compare
HannesWell
changed the title
|
@ceki would that also be interesting for the logback 1.3 branch? In general the same issue exists there are well, but the ee configuration probably has to be fine tuned a bit more due to the multi-release jar used for the modules-info. |
|
@HannesWell Yes, if not too much trouble, porting the PR to the 1.3 branch would be great. |
I'm currently about to do that. Looks like the first attempt is already successful and it is less trouble than expected. :) |
It was actually straight forward. Just created #641. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the explicitly specified, but out dated,
Bundle-RequiredExecutionEnvironment: JavaSE-1.6and let the maven-bundle-plugin instead add a automatically computed ee-requirement (therefore remove the_noeeinstruction). This ensures the OSGi-ExecutionEnvironment metadata are always up to date.Also remove all other explicitly configuration that can be derived automatically and is not necessary, like more Import-Package values or
_failok. Some of the explicitly imported packages are not even referenced in the code.Fixes https://jira.qos.ch/browse/LOGBACK-1728.