Fix for http://bugzilla.slf4j.org/show_bug.cgi?id=212

qos-ch · Mar 12, 2013 · 87b4999 · 87b4999
1 parent 67a67f4
commit 87b4999
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/jul-to-slf4j/src/main/java/org/slf4j/bridge/SLF4JBridgeHandler.java b/jul-to-slf4j/src/main/java/org/slf4j/bridge/SLF4JBridgeHandler.java
@@ -262,7 +262,7 @@ private String getMessageI18N(LogRecord record) {
       }
     }
     Object[] params = record.getParameters();
-    if (params != null) {
+    if (params != null && params.length > 0) {
       message = MessageFormat.format(message, params);
     }
     return message;

diff --git a/jul-to-slf4j/src/test/java/org/slf4j/bridge/SLF4JBridgeHandlerTest.java b/jul-to-slf4j/src/test/java/org/slf4j/bridge/SLF4JBridgeHandlerTest.java
@@ -168,6 +168,17 @@ public void testLogWithResourceBundleWithParameters() {
     assertEquals(expectedMsg3, le.getMessage());
   }
 
+  public void testLogWithPlaceholderNoParameters() {
+    SLF4JBridgeHandler.install();
+    String msg = "msg {}";
+    julLogger.logp(Level.INFO, "SLF4JBridgeHandlerTest", "testLogWithPlaceholderNoParameters", msg, new Object[0]);
+
+    assertEquals(1, listAppender.list.size());
+    LoggingEvent le = (LoggingEvent) listAppender.list.get(0);
+    assertEquals(LOGGER_NAME, le.getLoggerName());
+    assertEquals(msg, le.getMessage());
+  }
+
   void assertLevel(int index, org.apache.log4j.Level expectedLevel) {
     LoggingEvent le = (LoggingEvent) listAppender.list.get(index);
     assertEquals(expectedLevel, le.getLevel());