Add Automatic-Module-Name to MANIFEST #184
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this commit is to get a release 1.7.26 done with automatic module names for the four outward-facing modules. This allows the issues of service loader, module-info and so on to be sidestepped for now.
This PR is not intended to be merged onto the master branch. Instead, it is intended for there to be a new branch in slf4j starting at 1232e85 where this is the first commit on the branch. I can't get GitHub to do this automatically, so you'd need to create the branch in slf4j first, and I can then re-raise the PR against the new branch. Alternatively, you can cherry pick this commit onto the branch.
There is a case to add
Automatic-Module-Name
to the inward-facing (impl) jars, but I'm still working out what the best strategy for those is.thanks