Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name to MANIFEST #184

Closed
wants to merge 1 commit into from

Conversation

jodastephen
Copy link

The idea of this commit is to get a release 1.7.26 done with automatic module names for the four outward-facing modules. This allows the issues of service loader, module-info and so on to be sidestepped for now.

This PR is not intended to be merged onto the master branch. Instead, it is intended for there to be a new branch in slf4j starting at 1232e85 where this is the first commit on the branch. I can't get GitHub to do this automatically, so you'd need to create the branch in slf4j first, and I can then re-raise the PR against the new branch. Alternatively, you can cherry pick this commit onto the branch.

There is a case to add Automatic-Module-Name to the inward-facing (impl) jars, but I'm still working out what the best strategy for those is.

thanks

@varunnvs92
Copy link

Any plans on merging this change?

@ceki
Copy link
Member

ceki commented Jun 9, 2018

@varunnvs92
Copy link

Thanks. Based on @jodastephen's comment, you need to create a new branch and then merge these changes into the new branch. If you create the new branch, I can help with sending a PR with the changes.

@varunnvs92
Copy link

varunnvs92 commented Aug 13, 2018

@ceki
Any update on https://jira.qos.ch/browse/SLF4J-420?

What are your timelines on launching a version with JDK 9 module support?

@zoewangg
Copy link

Can we get some update here? Can you share the timelines for launching 1.8?

@jodastephen
Copy link
Author

Mostly fixed by bf50c49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants