Minor change to avoid getLevel to return null #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade on version because of the minor change on Category#getLevel to avoid to return null.
|
Please don't do this. If you want the effective level, call |
|
Thank you for the PR. Category.getLevel is meant to return the set level for the category/logger. Returning effective level from Category.getLevel would be semantically incorrect. More importantly, log4j-over-slf4j is not indented as a full replacement for log4j functionality but only as a stop-measure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have got a legacy project that access log4j api directly and does not expect to receive null on getLevel method. So I made a little change on version 1.7.30 to return effective level on getLevel, this avoid nullpointer on the legacy project.