Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of throwables in message formatting. #391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zorba128
Copy link

Related issue

This PR proposes improved exception extraction during message formatting.
It simplifies whole process and improves performance (avoids unnecessary construction of NormalizedParameters, avoids copying/truncating argsArray).

Still some work to be done - logger implementations can now be simplified in many cases.

@zorba128
Copy link
Author

relates to #166, but I believe this PR solves issue in more straightforward and efficient way (no need to double-parse message).

qos-ch#390

Signed-off-by: Marcin Kielar <zorba128@interia.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant