Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed parsing of nullable return types #122

Merged
merged 3 commits into from
Apr 18, 2017
Merged

Fixed parsing of nullable return types #122

merged 3 commits into from
Apr 18, 2017

Conversation

hiddeco
Copy link

@hiddeco hiddeco commented Apr 18, 2017 •
edited

The emitter assumed that the NullableType::$type holds a Name node, this is however not the case as it is a plain string.

@hiddeco hiddeco mentioned this pull request Apr 18, 2017
Closed
@hiddeco hiddeco changed the title Nullable return type failure Fixed parsing of nullable return types Apr 18, 2017
dbrumann
dbrumann approved these changes Apr 18, 2017
View reviewed changes
Copy link
Collaborator

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@timglabisch
Copy link
Collaborator

thanks a lot!

@timglabisch timglabisch merged commit b49cdc3 into qossmic:master Apr 18, 2017
@hiddeco hiddeco deleted the issue-113 branch April 18, 2017 20:19
@hiddeco hiddeco mentioned this pull request Apr 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hiddeco @timglabisch @dbrumann