Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent illegal offset warnings FQCN #125

Merged
merged 1 commit into from
Apr 29, 2017
Merged

Conversation

hiddeco
Copy link

@hiddeco hiddeco commented Apr 28, 2017

@xabbuh
Copy link
Member

xabbuh commented Apr 28, 2017

Can you expand the tests with an example that would fail without your patch?

@hiddeco
Copy link
Author

hiddeco commented Apr 29, 2017

@xabbuh not very easy to test as the FullQualified node class has a __toString() method which is picked up almost everywhere except when it's used as an array key. So the 'valid' results from the emitter will only cause problems 2-3 steps later.

Everything would however fail if we made string assertions for $classA and $classB in the Dependency constructor.

@timglabisch timglabisch merged commit 19bdf8a into qossmic:master Apr 29, 2017
@timglabisch
Copy link
Collaborator

this should help to prevent such issues: https://github.com/sensiolabs-de/deptrac/blob/master/Makefile#L19

@hiddeco thanks a lot =)

@hiddeco hiddeco deleted the issue-124 branch May 1, 2017 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants