Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move tests to top level dir #133

Merged
merged 1 commit into from
Sep 16, 2017
Merged

move tests to top level dir #133

merged 1 commit into from
Sep 16, 2017

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Sep 15, 2017

No description provided.

xabbuh
xabbuh requested changes Sep 15, 2017
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the namespace for the SelfUpdateCommandTest class looks totally wrong (it was by the way already wrong before this PR)

@xabbuh
Copy link
Member

xabbuh commented Sep 15, 2017

Why was it necessary for this change to update the composer.lock file?

@smoench smoench force-pushed the move-tests branch 2 times, most recently from baf3a1d to 4878a61 Compare September 15, 2017 14:26
@smoench
Copy link
Contributor Author

smoench commented Sep 15, 2017

SelfUpdateCommandTest -namespace has been fixed and composer.lock has been resetted

xabbuh
xabbuh requested changes Sep 15, 2017
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the fixtures file needs to be updated as well: https://github.com/sensiolabs-de/deptrac/blob/4878a61f0c937044766a5b8e701b6996f40d4559/examples/Fixture.depfile.yml#L1 (you were faster)

@timglabisch timglabisch self-requested a review September 15, 2017 19:34
@DavidBadura DavidBadura merged commit f917338 into master Sep 16, 2017
@DavidBadura DavidBadura deleted the move-tests branch September 16, 2017 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timglabisch timglabisch timglabisch approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smoench @xabbuh @timglabisch @DavidBadura