Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use namespaced phpunit TestCase #137

Merged
merged 2 commits into from
Jan 12, 2018
Merged

use namespaced phpunit TestCase #137

merged 2 commits into from
Jan 12, 2018

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Dec 22, 2017

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Dec 22, 2017

The version constraints for PHPUnit should then be changed to "phpunit/phpunit": "^4.8.35 || ^5.5".

@smoench
Copy link
Contributor Author

smoench commented Dec 22, 2017

I prefer #138 to be merged first

@smoench smoench merged commit 39d75dc into master Jan 12, 2018
@smoench smoench deleted the phpunit-namespaced branch January 12, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBadura DavidBadura DavidBadura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smoench @xabbuh @DavidBadura