#139 - use your own regex pattern #160
Conversation
smoench
force-pushed
the
custom-regex
branch
3 times, most recently
from
0732789
to
92455be
Compare
README.md
Outdated
| @@ -420,9 +420,11 @@ layers: | |||
| collectors: | |||
| - type: className | |||
| regex: .*Controller.* | |||
| predefined_delimiter: true | |||
There was a problem hiding this comment.
can you add a hint, that default is true?
There was a problem hiding this comment.
a better solution: have a classNameRegex type that takes a plain regex as argument (no fiddling with the regex besides validating it)
README.md
Outdated
| @@ -420,9 +420,11 @@ layers: | |||
| collectors: | |||
| - type: className | |||
There was a problem hiding this comment.
Something unrelated that I just noticed: this could simply be the class FQN, and then customising all this stuff would be a breeze.
There was a problem hiding this comment.
opened an issue #164
README.md
Outdated
| ``` | ||
|
|
||
| Every classname that matches the regular expression `.*Controller.*` becomes a part of the *controller* layer. | ||
| Every class name that matches the regular expression `.*Controller.*` becomes a part of the *controller* layer. | ||
| Set `predefined_delimiter` to `false` to use your own delimiters and/or modifiers. |
There was a problem hiding this comment.
This requires a practical example of how the generated regex looks like before/after.
README.md
Outdated
| @@ -420,9 +420,11 @@ layers: | |||
| collectors: | |||
| - type: className | |||
| regex: .*Controller.* | |||
| predefined_delimiter: true | |||
There was a problem hiding this comment.
a better solution: have a classNameRegex type that takes a plain regex as argument (no fiddling with the regex besides validating it)
| @@ -11,10 +11,12 @@ | |||
|
|
|||
| class ClassNameCollectorTest extends TestCase | |||
| { | |||
| public function dataProviderStatisfy() | |||
| public function dataProviderSatisfy() | |||
There was a problem hiding this comment.
A bit of denglish here: satisfiedRegexDataProvider maybe?
| */ | ||
| public function testStatisfy($configuration, $className, $expected) | ||
| public function testSatisfy(array $configuration, string $className, bool $expected) |
There was a problem hiding this comment.
Zame here about denglish: something wrong about the naming of this method
smoench
force-pushed
the
custom-regex
branch
2 times, most recently
from
ad61b47
to
047c796
Compare
|
@Ocramius I have updated this PR. I will fix the language issues in a follow-up PR :) |
fixes #139