Prototype: using php-parser NodeVisitor insteadof custom analysing methods #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoench
force-pushed
the
php-parser-node-visitor
branch
from
c84ba3c
to
b462890
Compare
|
Updated comparison with latest changes https://blackfire.io/profiles/compare/5f7f03ee-8041-4cdc-8ac9-72a1376f4173/graph Is there a practical example for the method collector? |
This was referenced Feb 12, 2019
smoench
force-pushed
the
php-parser-node-visitor
branch
from
935c2ea
to
a930f58
Compare
dergriewatz
reviewed
Feb 20, 2019
smoench
changed the title
smoench
force-pushed
the
php-parser-node-visitor
branch
2 times, most recently
from
2fb65e2
to
3097905
Compare
added 11 commits
February 22, 2019 15:00
smoench
force-pushed
the
php-parser-node-visitor
branch
from
3097905
to
435d844
Compare
DavidBadura
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would improve overall performance and would have a better structure for caching. The performance boost would be about ~65% https://blackfire.io/profiles/compare/af3990b3-a28d-437a-8d92-8ac28e9b8f3d/graph. For the comparison I used the provided deptrac file with lastest symfony master.
Following must be refactored: