Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions Output Formatter #305

Merged
merged 13 commits into from
Jun 5, 2020

Conversation

jtaylor100
Copy link
Contributor

Implements #282

Based it on the ConsoleOutputFormatter but left out any printing of the inheritance dependencies since I don't understand it. Perhaps it could be done later.

Tested using https://github.com/jtaylor100/random-reviews (basic Symfony project).

See https://github.com/jtaylor100/random-reviews/actions/runs/118086775 for how the output looks.

Any feedback appreciated.

@smoench
Copy link
Contributor

smoench commented Jun 2, 2020

@jtaylor100 Thank you @jtaylor100! Looks good to me.

Is there a way to support multilines for the output? We need to adapt inheritance dependencies as it might be hard to find the path / cause of such violation.

@smoench smoench added this to the 0.8 milestone Jun 4, 2020
@smoench smoench merged commit 259c200 into qossmic:master Jun 5, 2020
@smoench
Copy link
Contributor

smoench commented Jun 5, 2020

Thank you @jtaylor100!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants