Add Psalm #321
Merged
Add Psalm #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can the issue with the graph api suppressed? I already did this for phpstan. |
|
Thank you @DanielBadura! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wants to introduce psalm to the list of code analyzing tools for deptrac. For now on Level 3 this can be increased later on, if wanted.
Unfortunately i needed to add a baseline because of the graph api. It seems to be inconsistent in the 0.9.1 release.
On the master branch the
createVertexmethod completely changed. So i think the should go for the baseline for now and update as soon a new release got cut for graph and graphiz.