Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify formatter options #396

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Simplify formatter options #396

merged 1 commit into from
Oct 22, 2020

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Oct 16, 2020 •
edited
Loading

This PR simplifies how to enable formatters and passing options to them.

Before:

$ deptrac analyse depfile.yaml --formatter-console=0 --formatter-graphviz=1 --formatter-graphviz-dump-image=dump.png
$ deptrac analyse depfile.yaml --formatter-console=1 --formatter-console-report-uncovered=1 --formatter-github-actions=1 --formatter-github-actions-report-uncovered=1

After:

$ deptrac analyse depfile.yaml --formatter=graphviz --graphviz-dump-image=dump.png
$ deptrac analyse depfile.yaml --formatter=console --formatter=github-actions --report-uncovered

TODO

  • print deprecation messages
  • use InputOption::VALUE_NONE for all boolean options
  • update README

@smoench smoench added this to the 0.9 milestone Oct 16, 2020
@smoench smoench force-pushed the simplify-formatter-options branch 6 times, most recently from c545c5a to fe7cd7d Compare October 22, 2020 12:34
@smoench smoench merged commit 6d850dc into master Oct 22, 2020
@smoench smoench deleted the simplify-formatter-options branch October 22, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@smoench