Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Mark test classes as final #400

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Oct 20, 2020

This PR

  • marks test classes as final
  • runs make php-cs-fix

@localheinz
Copy link
Contributor Author

@smoench

Something is out of sync between tools running locally and on GitHub Actions.

Running

$ rm -rf tools
$ make tools-install

followed by

$ make php-cs-check

yields

PHP_CS_FIXER_FUTURE_MODE=1 ./tools/php-cs-fixer fix --allow-risky=yes --diff --diff-format=udiff --using-cache=no --verbose --dry-run
Loaded config default from "/Users/am/Sites/sensiolabs-de/deptrac/.php_cs.dist".
.............................................................................................................................................................                                                                                                                                                 157 / 157 (100%)
Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error

Checked all files in 1.861 seconds, 12.000 MB memory used

@smoench
Copy link
Contributor

smoench commented Oct 20, 2020

Well, yesterday I merged your PR #397 which enables the final_static_access fixer. So GitHub Actions seems to be correct.

What version of php-cs-fixer got installed on your machine and what version of phive are you using? Once I had an issue with phive which has installed only the latest 2.15 version of php-cs-fixer. You might have a look at .phive/phars.xml where fixed versions are defined.

@localheinz
Copy link
Contributor Author

@smoench

Well, yesterday I merged your PR #397 which enables the final_static_access fixer. So GitHub Actions seems to be correct.

🤦 Looks like I forgot to rebase on top of master - updated!

@localheinz localheinz marked this pull request as ready for review October 20, 2020 08:45
@localheinz localheinz changed the title Enhancement: Mark classes as final Enhancement: Mark test classes as final Oct 20, 2020
@smoench smoench merged commit 0a2da45 into qossmic:master Oct 20, 2020
@smoench
Copy link
Contributor

smoench commented Oct 20, 2020

Thank you, @localheinz!

FYI: While we are waiting for the next release you can already download the latest build artifact (phar-file) from GitHub Actions which includes your contributions

@localheinz localheinz deleted the feature/final branch October 20, 2020 11:44
@localheinz
Copy link
Contributor Author

Thank you, @smoench!

@smoench smoench added this to the 0.9 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants