Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Import configuration files #489

Merged
merged 3 commits into from
Feb 18, 2021
Merged

[RFC] Import configuration files #489

merged 3 commits into from
Feb 18, 2021

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Feb 11, 2021

resolves #486
resolves #453

@smoench smoench force-pushed the import-config branch 2 times, most recently from 3e2c632 to 342b526 Compare February 12, 2021 12:12
@smoench smoench force-pushed the import-config branch 4 times, most recently from 8e30097 to a4de8c8 Compare February 12, 2021 14:59
@smoench smoench marked this pull request as ready for review February 12, 2021 15:28
@smoench smoench force-pushed the import-config branch 4 times, most recently from c4af83c to ba08cac Compare February 18, 2021 15:09
@smoench smoench added this to the 0.12.0 milestone Feb 18, 2021
@MartinMystikJonas
Copy link

I just successfully used updated version on all of our projects and it works perfectly.

@MartinMystikJonas
Copy link

I have just one idea for small improvement. It would be useful if it would be possible to pass parameters to imported configs. Specifically I would like to pass project root namespace nae so it can be used in collector in imported config. Something like:

parameters:
  project: "MyProject"

imports:
  - common.depfile.yaml

Included common.depfile.yaml:

  - name: Services
    collectors:
      - type: className
        regex: %project%\\Services\\.*

would be interpreted as:

  - name: Services
    collectors:
      - type: className
        regex: MyProject\\Services\\.*

But it is something I can live without.

@smoench
Copy link
Contributor Author

smoench commented Feb 18, 2021

Thanks for your feedback.

Can you open a new issue for the parameters feature request?

@MartinMystikJonas
Copy link

#493

@smoench smoench merged commit 697e446 into master Feb 18, 2021
@dbrumann dbrumann deleted the import-config branch July 21, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending/ including config Paths relative to depfile
2 participants