Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] report warnings about classes are in two or more layers #499

Merged
merged 1 commit into from
Feb 26, 2021
Merged

[POC] report warnings about classes are in two or more layers #499

merged 1 commit into from
Feb 26, 2021

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Feb 22, 2021

resolves #488

@smoench smoench mentioned this pull request Feb 22, 2021
Closed
@staabm
Copy link
Contributor

staabm commented Feb 23, 2021

tested locally. seem to work fine:

$ php deptrac.phar analyze depfile.yml
 30/30 [============================] 100%

 --------------------------------------------------------------------------------------------------------------------------------------------------------
  Warnings
 --------------------------------------------------------------------------------------------------------------------------------------------------------
  POM\auth\persistence\UserRecord is in more than one layer ["Persistence", "ActiveRecord"]. It is recommend that one class should only be in one layer.
 --------------------------------------------------------------------------------------------------------------------------------------------------------


 -------------------- -----
  Report
 -------------------- -----
  Violations           0
  Skipped violations   0
  Uncovered            28
  Allowed              210
 -------------------- -----

@staabm
Copy link
Contributor

staabm commented Feb 23, 2021

just a idea: should the number of warnings be part of the final summary?


 -------------------- -----
  Report
 -------------------- -----
  Violations           0
  Skipped violations   0
  Uncovered            28
  Allowed              210
 -------------------- -----

@smoench smoench force-pushed the classes-in-two-or-more-layers branch 2 times, most recently from 5864305 to 86740de Compare February 26, 2021 07:44
@smoench smoench force-pushed the classes-in-two-or-more-layers branch from 86740de to bab943c Compare February 26, 2021 07:56
@smoench smoench merged commit 2bff6f1 into master Feb 26, 2021
@smoench smoench deleted the classes-in-two-or-more-layers branch February 26, 2021 08:01
@smoench
Copy link
Contributor Author

smoench commented Feb 26, 2021

@staabm and @malteschlueter thanks for the feedback :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm left review comments

@malteschlueter malteschlueter malteschlueter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How are classes handled which are part of several layers
3 participants
@smoench @staabm @malteschlueter