Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report uncovered as errors with GithubActionOutputFormatter #523

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Mar 12, 2021

resolves #510

@smoench smoench added this to the 0.12.0 milestone Mar 12, 2021
@smoench smoench merged commit 7892f52 into master Mar 12, 2021
@smoench smoench deleted the github-action-error-with-fail-on-uncovered branch March 12, 2021 07:54
@clxmstaab
Copy link
Contributor

clxmstaab commented Mar 12, 2021

thx for your fix.

should this be something general (not just for the github error formatting?)

having messages with different error levels depending on the formatter might be a problem IMO.

@smoench
Copy link
Contributor Author

smoench commented Mar 12, 2021

I also updated the (default) TableOutputFormatter but that was just using red instead of yellow as color.

If one interested for the same behavior for junit or graphviz I would be happy about an PR. The XmlOutputFormatter doesn't report uncovered yet and the ConsoleOutputFormatter might be removed the next time.

@clxmstaab
Copy link
Contributor

oh I see. thx for the insights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emit errors instead of warnings, when --report-uncovered --fail-on-uncovered is used in combination
2 participants