Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not counting use statements #571

Merged
merged 19 commits into from
Jun 15, 2021
Merged

Not counting use statements #571

merged 19 commits into from
Jun 15, 2021

Conversation

patrickkusebauch
Copy link
Collaborator

Closes #569

@patrickkusebauch
Copy link
Collaborator Author

My bad, stale cache. 🤦

@patrickkusebauch patrickkusebauch changed the title WIP: Not counting use statements Not counting use statements Jun 10, 2021
Copy link
Collaborator

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things.

README.md Outdated Show resolved Hide resolved
src/Configuration/Configuration.php Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/Configuration/ConfigurationAnalyzer.php Outdated Show resolved Hide resolved
src/Configuration/ConfigurationAnalyzer.php Show resolved Hide resolved
src/Configuration/ConfigurationAnalyzer.php Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@dbrumann dbrumann merged commit aa688dc into qossmic:main Jun 15, 2021
@patrickkusebauch patrickkusebauch deleted the config_file_parameters branch June 15, 2021 10:15
@smoench
Copy link
Contributor

smoench commented Jun 16, 2021

@patrickkusebauch thanks for contributing so much to deptrac.

Here my 2 cents to this PR. I think not counting use statements are a good idea. But I'm not really happy about the implementation. Putting the configuration through every layer down to FileReferenceBuilder should have been an indicator. The result of the AstRunner can be cached and depending when deptrac was executed and when the option was set we might get an different reporting. My proposal would move up to https://github.com/qossmic/deptrac/blob/main/src/DependencyEmitter/BasicDependencyEmitter.php or https://github.com/qossmic/deptrac/blob/main/src/RulesetEngine.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count use statements
3 participants