JUnit output formatter - unmatched skipped violations

[patrickkusebauch]

Closes #568

Adding this (sample) output at the beginning of the file.

<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
  <testsuite id="0" package="" name="Unmatched skipped violations" hostname="localhost" tests="0" failures="0" skipped="0" errors="4" time="0">
    <failure message="Skipped violation &quot;TrainingCompass\Saas\Dashboards\Controls\Dashboard\LayoutControl&quot; for &quot;TrainingCompass\Saas\Branding\Personal\DashboardPresenter&quot; was not matched." type="WARNING"/>
    <failure message="Skipped violation &quot;TrainingCompass\Saas\Dashboards\Controls\Dashboard\LayoutControlFactory&quot; for &quot;TrainingCompass\Saas\Branding\Personal\DashboardPresenter&quot; was not matched." type="WARNING"/>
    <failure message="Skipped violation &quot;TrainingCompass\Saas\Dashboards\Controls\DashboardLayoutConfig\LayoutConfigControl&quot; for &quot;TrainingCompass\Saas\Branding\Personal\ProfilePresenter&quot; was not matched." type="WARNING"/>
    <failure message="Skipped violation &quot;TrainingCompass\Saas\Dashboards\Controls\DashboardLayoutConfig\LayoutConfigControlFactory&quot; for &quot;TrainingCompass\Saas\Branding\Personal\ProfilePresenter&quot; was not matched." type="WARNING"/>
  </testsuite>

[dbrumann]

Looks good. Can you please add or adapt one of the existing test cases for the formatter as well?

[patrickkusebauch]

@dbrumann will do. Just waiting for @Khartir to confirm this is the format he was looking for since he opened the issue and I don't use JUnit myself. Once he says the output solves the issue, I will add tests.

[Khartir]

I don't know the specification that well myself, which is why I didn't submit a PR for this, but I think if the testsuite declares this as errors, it should contain error-nodes, not failure-nodes:

<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
  <testsuite id="0" package="" name="Unmatched skipped violations" hostname="localhost" tests="0" failures="0" skipped="0" errors="4" time="0">
    <error message="Skipped violation &quot;TrainingCompass\Saas\Dashboards\Controls\Dashboard\LayoutControl&quot; for &quot;TrainingCompass\Saas\Branding\Personal\DashboardPresenter&quot; was not matched." type="WARNING"/>
    <error message="Skipped violation &quot;TrainingCompass\Saas\Dashboards\Controls\Dashboard\LayoutControlFactory&quot; for &quot;TrainingCompass\Saas\Branding\Personal\DashboardPresenter&quot; was not matched." type="WARNING"/>
    <error message="Skipped violation &quot;TrainingCompass\Saas\Dashboards\Controls\DashboardLayoutConfig\LayoutConfigControl&quot; for &quot;TrainingCompass\Saas\Branding\Personal\ProfilePresenter&quot; was not matched." type="WARNING"/>
    <error message="Skipped violation &quot;TrainingCompass\Saas\Dashboards\Controls\DashboardLayoutConfig\LayoutConfigControlFactory&quot; for &quot;TrainingCompass\Saas\Branding\Personal\ProfilePresenter&quot; was not matched." type="WARNING"/>
  </testsuite>

Apart from that, this is exactly what I had in mind, thank you.

[patrickkusebauch]

I checked the official docs and you are right. You have it. Along with a test. 😄