Transitive dependencies #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkusebauch
changed the title
smoench
reviewed
Jun 16, 2021
smoench
reviewed
Jun 16, 2021
| private function getTransitiveDependencies(string $layerName, array $previousLayers): array | ||
| { | ||
| if (in_array($layerName, $previousLayers, true)) { | ||
| throw new InvalidArgumentException('Circular ruleset dependency for layer '.$layerName.' depending on: '.implode('->', $previousLayers)); |
There was a problem hiding this comment.
How about a specific exception class, e.g. CircularTransitiveRulesetDependencyDetectedException?
There was a problem hiding this comment.
I tend to not create specialized exception classes if the code that is catching the exceptions does not need it to differentiate it from another exception. But that is my style/convention, if you insist, I can create it.
|
And another one 👍 |
This was referenced Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #202
Closes: #158
In the end, since I was able to contain the changes to one class, it is easier than expected.