Support for file, function and superglobal tokens #634
Conversation
patrickkusebauch
changed the title
|
Tons of work! I don't understand all of the changes but I'm excited for the high-level concepts. Thank you!! |
|
Thanks a lot, @patrickkusebauch. I like the direction this is taking. Happy to merge this 👍 |
| - `class` (default) - analyzes class definitions for everything apart from superglobal usage. | ||
| - `class_superglobal` - analyzes class definitions for superglobal usage. | ||
| - `use` (default) - analyzes file definitions for use statements. | ||
| - `file` - analyzes file for everything apart from use statements and function/class definitions. | ||
| - `function` - analyzes function definitions for everything apart from superglobal usage. | ||
| - `function_superglobal` - analyzes function definitions for superglobal usage. | ||
|
|
There was a problem hiding this comment.
I am wondering about this paragraph.. doesn't it mean is only possible to scan for superglobals within functions or classes, but not in plain php files?
There was a problem hiding this comment.
Well, no. See https://github.com/qossmic/deptrac/blob/main/tests/DependencyEmitter/FileDependencyEmitterTest.php#L37. I recall that I differentiated class_superglobal as not to break current behavior.
function_superglobal - I am not that sure about it. I think function support was implemented in a previous commit, so the same reasoning? I don't recall honestly.
Task-list:
In a separate PRs, I would suggest the following:
debug:classis kind of meaningless right now)Closes: #331
Closes: #473
Closes: #582
Closes: #594