Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyze -> analyse #641

Merged
merged 2 commits into from
Jul 21, 2021
Merged

analyze -> analyse #641

merged 2 commits into from
Jul 21, 2021

Conversation

patrickkusebauch
Copy link
Collaborator

Closes: #575

I chose analyse since it is consistent with naming used by tools like PHPStan and Psalm.

You should also change the wording in build tools, I do not have permissions to do that.

Copy link
Collaborator

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. Can you please change the version in the deprecation?

src/Configuration/Definition.php Outdated Show resolved Hide resolved
@dbrumann dbrumann merged commit a605a21 into qossmic:main Jul 21, 2021
@patrickkusebauch patrickkusebauch deleted the analyse branch July 21, 2021 16:25
@patrickkusebauch
Copy link
Collaborator Author

patrickkusebauch commented Jul 21, 2021

@dbrumann can you change analyze to analyse in the .build directory, please?

@dbrumann
Copy link
Collaborator

Yes, will do it in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix naming inconsistencies analyze vs. analyse
2 participants